From: Michael Widenius
Date: October 24 2009 2:42pm
Subject: Re: Style proposal [Re: Coding style changes of 2009-06-26 now in the 
	guidelines]
List-Archive: http://lists.mysql.com/internals/37453
Message-Id: <19171.4713.146332.865307@narttu.askmonty.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable


Hi!

>>>>> "MARK" =3D=3D MARK CALLAGHAN <mdcallag@stripped> writes:

<cut>

>> Another way to see this is also that you should not force the people=

>> that produces the most code to code in a style they don't like. =A0T=
hat
>> will just make these people less productive and over time do somethi=
ng
>> else than produce code for that project.

MARK> Ignoring the issue of has produced versus will produce, you assum=
e
MARK> that 'lines of code' is all that counts. That is an awful metric =
when
MARK> used in isolation. Someone who writes a lot is less productive wh=
en:
MARK> * other people spend years fixing bugs in that code
MARK> * production users spend years dealing with problems from that co=
de
MARK> * that code is difficult to reuse (no comments, no design notes, =
lousy
MARK> structure)
MARK> * that code is difficult for others to maintain
MARK> * that code required too many lines of code

Replace 'produce code' with 'produce the most useful code' and we
should be quite close.  Counting 'diff' lines (ignore some automatic
big changes and merges) is a rough estimate, but usually a good and
easy start. After that, humans could go over the results and adjust
things to we also take the other aspects of the code the produce into
aspect.

Regards,
Monty