List:Internals« Previous MessageNext Message »
From:MARK CALLAGHAN Date:October 21 2009 11:36am
Subject:Re: Style proposal [Re: Coding style changes of 2009-06-26 now in the
guidelines]
View as plain text  
On Wed, Oct 21, 2009 at 2:41 AM, Michael Widenius <monty@stripped> wrote:
>
> Hi!
>
>>>>>> "Ingo" == Ingo Strüwing <Ingo.Struewing@stripped>
> writes:
>

[cut]

>>> I would also suggest that you never accept a code style
>>> convention that is not accepted by those that are affected by it
>>> (I those that produced code to MySQL or it's variants).
>
> Ingo> Agree. That's the reason why I raised a request for ideas, how this
> Ingo> could be done transparently. I would like to have a voting system that
> Ingo> accepts a vote from everybody, who works with MySQL code directly, and
> Ingo> refuse votes from other people.
>
> Sounds much better than the current procedure.  Note that to get this
> right, the vote should also be weighed with how much cod on has
> produced in the code base!
>

Has produced?
Or will produce?

> After all, we don't want to have people that commit a lot of code to
> not agree with the coding style that is imposed on them and makes the
> code harder (for them) to read and write.

For this reason votes should be weighted by:
* how much code each person will write
* how much code each person will read

What are the scale factors for:
* code read/written in the past versus to be written in the future?
* code read versus code written?

Do you get votes for lines removed?
Do votes get transferred from author to bug fixer when someone fixes
bugs in said code?

Do you get votes for ports or backports? I know people who worked very
hard to backport batch key access and connection pool. They deserve
some votes for that effort. But when a port is as simple as running
patch, fewer votes should be assigned.

Do you get votes for whitespace? Heikki uses much more whitespace in
InnoDB. Perhaps he saw this coming and tried to inflate his vote
count. Heikki is very clever.

If votes also get assigned for code read, then we should strive to
make our code as unreadable as possible to avoid diluting our votes
for writing it.

Do you get votes for comments? Given the lack of comments in header
files I think I know the answer to that. But I think that we should
give out votes for lines of comments. I would use comments to scare
away readers and avoid diluting my votes.

I think there should extra votes if you read code and then write a
unit test for it.

Does work done on branches other than the official MySQL branch count?
Maybe we could extend the 'karma' feature from Launchpad for this and
only count votes for work done on branches there. But I did a lot of
work on non-Launchpad branches so that makes me unhappy.

-- 
Mark Callaghan
mdcallag@stripped
Thread
Coding style changes of 2009-06-26 now in the guidelinesIngo Strüwing17 Oct
  • Re: Coding style changes of 2009-06-26 now in the guidelinesMARK CALLAGHAN17 Oct
    • Re: Coding style changes of 2009-06-26 now in the guidelinesMichael Widenius18 Oct
      • Re: Coding style changes of 2009-06-26 now in the guidelinesMARK CALLAGHAN18 Oct
        • Re: Coding style changes of 2009-06-26 now in the guidelinesMichael Widenius18 Oct
          • Re: Coding style changes of 2009-06-26 now in the guidelinesJay Pipes18 Oct
          • Re: Coding style changes of 2009-06-26 now in the guidelinesMARK CALLAGHAN18 Oct
            • Re: Coding style changes of 2009-06-26 now in the guidelinesMichael Widenius19 Oct
    • Re: Coding style changes of 2009-06-26 now in the guidelinesIngo Strüwing19 Oct
      • Re: Coding style changes of 2009-06-26 now in the guidelinesMats Kindahl19 Oct
        • RE: Coding style changes of 2009-06-26 now in the guidelinesVladislav Vaintroub19 Oct
          • Re: Coding style changes of 2009-06-26 now in the guidelinesMats Kindahl19 Oct
            • RE: Coding style changes of 2009-06-26 now in the guidelinesVladislav Vaintroub19 Oct
            • Re: Coding style changes of 2009-06-26 now in the guidelinesRoy Lyseng19 Oct
          • RE: Coding style changes of 2009-06-26 now in the guidelinesMichael Widenius21 Oct
      • Re: Coding style changes of 2009-06-26 now in the guidelinesMARK CALLAGHAN19 Oct
        • Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Ingo Strüwing19 Oct
          • re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Michael Widenius21 Oct
            • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Ingo Strüwing21 Oct
              • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Michael Widenius21 Oct
                • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in the guidelines]MARK CALLAGHAN21 Oct
                  • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in the guidelines]Michael Widenius21 Oct
                  • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Konstantin Osipov23 Oct
                    • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Jay Pipes23 Oct
                • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Ingo Strüwing22 Oct
                  • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Michael Widenius22 Oct
                    • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Ingo Strüwing22 Oct
                      • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Michael Widenius23 Oct
                    • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in the guidelines]MARK CALLAGHAN23 Oct
                      • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in the guidelines]Michael Widenius24 Oct
        • Re: Coding style changes of 2009-06-26 now in the guidelinesMichael Widenius21 Oct
          • Re: Coding style changes of 2009-06-26 now in the guidelinesMARK CALLAGHAN21 Oct
            • Re: Coding style changes of 2009-06-26 now in the guidelinesMichael Widenius21 Oct