From: Michael Widenius
Date: October 21 2009 9:41am
Subject: Re: Style proposal [Re: Coding style changes of 2009-06-26 now in the
 guidelines]
List-Archive: http://lists.mysql.com/internals/37428
Message-Id: <19166.55089.721380.673998@narttu.askmonty.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable


Hi!

>>>>> "Ingo" =3D=3D Ingo Str=FCwing <Ingo.Struewing@stripped> writes:

Ingo> Hi Monty,
Ingo> Michael Widenius, 21.10.2009 01:27:

Ingo> ...
>> Then add also as a pending proposal to keep the current code style
>> convention.

Ingo> Are you serious? IMHO, this would be equivalent to vote against e=
very
Ingo> change proposal. Or do you mean a proposal to never ever change t=
he
Ingo> "current code style" again?

No, I meant for this particular issue.

>> I would also suggest that you never accept a code style
>> convention that is not accepted by those that are affected by it
>> (I those that produced code to MySQL or it's variants).

Ingo> Agree. That's the reason why I raised a request for ideas, how th=
is
Ingo> could be done transparently. I would like to have a voting system=
 that
Ingo> accepts a vote from everybody, who works with MySQL code directly=
, and
Ingo> refuse votes from other people.

Sounds much better than the current procedure.  Note that to get this
right, the vote should also be weighed with how much cod on has
produced in the code base!

After all, we don't want to have people that commit a lot of code to
not agree with the coding style that is imposed on them and makes the
code harder (for them) to read and write.

Ingo> The procedure, we used last time, was relatively near to it IMHO,=
 but,
Ingo> as you pointed out, community developers were poorly involved.

Don't forget original developers of the code in question that may not
like that you are touching or changing their code without their
consent.

Another issue that some of the code is also used in other project and
any style change in MySQL will over time also affect these projects
when they want to sync/update the code.

Regards,
Monty