List:Internals« Previous MessageNext Message »
From:Michael Widenius Date:October 21 2009 9:41am
Subject:Re: Style proposal [Re: Coding style changes of 2009-06-26 now in the
guidelines]
View as plain text  
Hi!

>>>>> "Ingo" == Ingo Strüwing <Ingo.Struewing@stripped> writes:

Ingo> Hi Monty,
Ingo> Michael Widenius, 21.10.2009 01:27:

Ingo> ...
>> Then add also as a pending proposal to keep the current code style
>> convention.

Ingo> Are you serious? IMHO, this would be equivalent to vote against every
Ingo> change proposal. Or do you mean a proposal to never ever change the
Ingo> "current code style" again?

No, I meant for this particular issue.

>> I would also suggest that you never accept a code style
>> convention that is not accepted by those that are affected by it
>> (I those that produced code to MySQL or it's variants).

Ingo> Agree. That's the reason why I raised a request for ideas, how this
Ingo> could be done transparently. I would like to have a voting system that
Ingo> accepts a vote from everybody, who works with MySQL code directly, and
Ingo> refuse votes from other people.

Sounds much better than the current procedure.  Note that to get this
right, the vote should also be weighed with how much cod on has
produced in the code base!

After all, we don't want to have people that commit a lot of code to
not agree with the coding style that is imposed on them and makes the
code harder (for them) to read and write.

Ingo> The procedure, we used last time, was relatively near to it IMHO, but,
Ingo> as you pointed out, community developers were poorly involved.

Don't forget original developers of the code in question that may not
like that you are touching or changing their code without their
consent.

Another issue that some of the code is also used in other project and
any style change in MySQL will over time also affect these projects
when they want to sync/update the code.

Regards,
Monty
Thread
Coding style changes of 2009-06-26 now in the guidelinesIngo Strüwing17 Oct
  • Re: Coding style changes of 2009-06-26 now in the guidelinesMARK CALLAGHAN17 Oct
    • Re: Coding style changes of 2009-06-26 now in the guidelinesMichael Widenius18 Oct
      • Re: Coding style changes of 2009-06-26 now in the guidelinesMARK CALLAGHAN18 Oct
        • Re: Coding style changes of 2009-06-26 now in the guidelinesMichael Widenius18 Oct
          • Re: Coding style changes of 2009-06-26 now in the guidelinesJay Pipes18 Oct
          • Re: Coding style changes of 2009-06-26 now in the guidelinesMARK CALLAGHAN18 Oct
            • Re: Coding style changes of 2009-06-26 now in the guidelinesMichael Widenius19 Oct
    • Re: Coding style changes of 2009-06-26 now in the guidelinesIngo Strüwing19 Oct
      • Re: Coding style changes of 2009-06-26 now in the guidelinesMats Kindahl19 Oct
        • RE: Coding style changes of 2009-06-26 now in the guidelinesVladislav Vaintroub19 Oct
          • Re: Coding style changes of 2009-06-26 now in the guidelinesMats Kindahl19 Oct
            • RE: Coding style changes of 2009-06-26 now in the guidelinesVladislav Vaintroub19 Oct
            • Re: Coding style changes of 2009-06-26 now in the guidelinesRoy Lyseng19 Oct
          • RE: Coding style changes of 2009-06-26 now in the guidelinesMichael Widenius21 Oct
      • Re: Coding style changes of 2009-06-26 now in the guidelinesMARK CALLAGHAN19 Oct
        • Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Ingo Strüwing19 Oct
          • re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Michael Widenius21 Oct
            • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Ingo Strüwing21 Oct
              • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Michael Widenius21 Oct
                • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in the guidelines]MARK CALLAGHAN21 Oct
                  • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in the guidelines]Michael Widenius21 Oct
                  • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Konstantin Osipov23 Oct
                    • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Jay Pipes23 Oct
                • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Ingo Strüwing22 Oct
                  • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Michael Widenius22 Oct
                    • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Ingo Strüwing22 Oct
                      • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in theguidelines]Michael Widenius23 Oct
                    • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in the guidelines]MARK CALLAGHAN23 Oct
                      • Re: Style proposal [Re: Coding style changes of 2009-06-26 now in the guidelines]Michael Widenius24 Oct
        • Re: Coding style changes of 2009-06-26 now in the guidelinesMichael Widenius21 Oct
          • Re: Coding style changes of 2009-06-26 now in the guidelinesMARK CALLAGHAN21 Oct
            • Re: Coding style changes of 2009-06-26 now in the guidelinesMichael Widenius21 Oct