From: Michael Widenius
Date: October 20 2009 11:27pm
Subject: re: Style proposal [Re: Coding style changes of 2009-06-26 now in the
 guidelines]
List-Archive: http://lists.mysql.com/internals/37419
Message-Id: <19166.18253.207541.848415@narttu.askmonty.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable


Hi!

>>>>> "Ingo" =3D=3D Ingo Str=FCwing <Ingo.Struewing@stripped> writes:

Ingo> Hi Mark,
Ingo> thank you. I added it to the list of pending proposals:
Ingo> http://forge.mysql.com/wiki/Coding_Style#Pending_propsals

Ingo> MARK CALLAGHAN, 19.10.2009 17:07:

Ingo> ...
>> I don't expect existing code to be changed. But it would be nice for=

>> people to slowly fix things when they edit code. My requests are:
>> 1) Use Unix style for functions (return type is int, 0 =3D=3D succes=
s).
>> The current rule doesn't mention the return type. Do not use
>> bool/my_bool for this with FALSE=3D=3Derrror and TRUE=3D=3Dsuccess i=
n place of
>> 1.
>> 2) Use _Bool for my_bool on platforms that support C99
>> 3) Do not use the literals 0 and 1 in place of FALSE and TRUE

Then add also as a pending proposal to keep the current code style
convention.  I would also suggest that you never accept a code style
convention that is not accepted by those that are affected by it
(I those that produced code to MySQL or it's variants).

Regards,
Monty