On Mon, Oct 19, 2009 at 12:01 AM, Ingo Strüwing <Ingo.Struewing@stripped> wrote:
> Hi Mark,
> MARK CALLAGHAN, 17.10.2009 20:31:
>> * Functions should return zero on success, and non-zero on
>> so you can do:
>> Can this be extended to state that these functions should return int
>> rather than bool/my_bool? Some functions today use bool/my_bool and
>> return TRUE on error. I have to read the code for these to figure out
>> whether TRUE is returned on error.
> thanks for the suggestion. Is this a formal request to the MySQL Server
> coding style government committee?
> In this case, please add, what the implementation strategy should be:
> Change all existing code, or let only new code follow the proposal.
I don't expect existing code to be changed. But it would be nice for
people to slowly fix things when they edit code. My requests are:
1) Use Unix style for functions (return type is int, 0 == success).
The current rule doesn't mention the return type. Do not use
bool/my_bool for this with FALSE==errror and TRUE==success in place of
2) Use _Bool for my_bool on platforms that support C99
3) Do not use the literals 0 and 1 in place of FALSE and TRUE
> Ingo Strüwing, Database Group
> Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
> Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf
> Vorsitzender des Aufsichtsrates: Martin Häring HRB München 161028