> -----Original Message-----
> From: Mats.Kindahl@stripped [mailto:Mats.Kindahl@stripped] On Behalf Of
> Mats Kindahl
> Sent: Monday, October 19, 2009 3:05 PM
> To: Vladislav Vaintroub
> Cc: 'Ingo Strüwing'; 'MARK CALLAGHAN'; 'MySQL Internal'
> Subject: Re: Coding style changes of 2009-06-26 now in the guidelines
> Yes, I also think that it is strange to have the "error convention"
> with a
> return value of my_bool.
> I would prefer to have it as you suggest in the first alternative with
> exception that I would like to have 0 as "No Error" and anything else
> as an
> error code. This is how it works in the code now, and the errno
> approach have
> proven to be problematic for multi-threaded code, so I would like to
> avoid that
> as far as possible.
This is fine to me too. I'm mainly bothered by the all-but-obvious usage of
my_bool as the return code.