Re: Coding style changes of 2009-06-26 now in the guidelines

[Ingo Strüwing]

Hi Mark,

MARK CALLAGHAN, 17.10.2009 20:31:

...
>     *  Functions should return zero on success, and non-zero on error,
> so you can do:
> 
> Can this be extended to state that these functions should return int
> rather than bool/my_bool? Some functions today use bool/my_bool and
> return TRUE on error. I have to read the code for these to figure out
> whether TRUE is returned on error.

thanks for the suggestion. Is this a formal request to the MySQL Server
coding style government committee?

http://forge.mysql.com/wiki/MySQL_Internals_Coding_Guidelines#How_we_maintain_the_server_coding_guidelines

In this case, please add, what the implementation strategy should be:
Change all existing code, or let only new code follow the proposal.

Regards
Ingo
-- 
Ingo Strüwing, Database Group
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schröder,   Wolfgang Engels,   Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring   HRB München 161028