List:Internals« Previous MessageNext Message »
From:Zardosht Kasheff Date:September 29 2009 3:30pm
Subject:Re: can show engine status ever return an error?
View as plain text  
Thanks Sergei,

I filed the following bug:

http://bugs.mysql.com/bug.php?id=47719

-Zardosht

On Tue, Sep 29, 2009 at 11:26 AM, Sergei Golubchik <serg@stripped> wrote:
> Hi, Zardosht!
>
> On Sep 29, Zardosht Kasheff wrote:
>>
>>
>> In the function ha_show_status, in handler.cc, I see the following
>> code to end the function:
>>
>>   if (!result)
>>     my_eof(thd);
>>   return result;
>> }
>>
>> So, if the handlerton's show_status function successfully returns,
>> my_eof(thd) is called, and the assert is not hit in protocol.cc.
>> However, if show_status returns an error, then nothing is called here,
>> causing the assert.
>
> This looks like a bug to me.
>
>> Is there something simple and safe that can be done that allows
>> show_status to return an error in some cases, but not causing a crash?
>
> The simple and safe workaround that you can do is to call my_error()
> when you have an error. It will set the proper status in the
> Diagnostics_area.
>
> Regards / Mit vielen Grüßen,
> Sergei
>
> --
>   __  ___     ___ ____  __
>  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik
> <serg@stripped>
>  / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
> /_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München
> 161028
>       <___/                
>  Sonnenallee 1, 85551 Kirchheim-Heimstetten
> Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel
> Vorsitzender des Aufsichtsrates: Martin Häring
>
Thread
can show engine status ever return an error?Zardosht Kasheff29 Sep
  • Re: can show engine status ever return an error?Sergei Golubchik29 Sep
    • Re: can show engine status ever return an error?Zardosht Kasheff29 Sep
  • Re: can show engine status ever return an error?Konstantin Osipov29 Sep