List:Internals« Previous MessageNext Message »
From:Sergei Golubchik Date:July 10 2009 6:07pm
Subject:Re: Implementation - per query variable setting GSoC project
View as plain text  
Hi, Joseph!

On Jul 09, Joseph Lukas wrote:
>
> I manually call the set function.  I plan on noting and copying the 
> SQLCOM_SET case functions in order to ensure the same checks are used on 
> the set statements.  I however am copying the SET case in order to prevent 
> too many my_ok statements to be output.  I will note in both sections that 
> the contents is copied elsewhere.  I did however do a mysql_execute_command 
> recursive call to perform the select statement.  I figured in order to 
> ensure it will work with any future changes to the select methods the 
> overhead of a single recursive call was acceptable.  SET statements seem 
> less likely to change as they are not really dependent on creating new 
> methods for optimization etc. that would cause possible implementation 
> changes.

You've probably forgot what was saying in mails
http://lists.mysql.com/internals/36702
http://lists.mysql.com/internals/36751
http://lists.mysql.com/internals/36820

to repeat:
"
  the syntax should be

    SET STATEMENT <assignments> <any statement>

  not

    SET STATEMENT <assignments> <select>

  For example, this should work too:

    SET STATEMENT myisam_sort_buffer_size=800M, myisam_repair_threads=2 OPTIMIZE TABLE t1;
"

in other words, you cannot use a solution that is specifically works
only with SQLCOM_SELECT.

Regards / Mit vielen Grüßen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring
Thread
Empty var_list issue - per query variable setting GSoC projectJoseph Lukas9 Jul
  • Re: Empty var_list issue - per query variable setting GSoC projectSergei Golubchik9 Jul
    • Re: Empty var_list issue - per query variable setting GSoC projectJoseph Lukas9 Jul
    • Implementation - per query variable setting GSoC projectJoseph Lukas9 Jul
      • Re: Implementation - per query variable setting GSoC projectSergei Golubchik11 Jul
        • Re: Implementation - per query variable setting GSoC projectJoseph Lukas11 Jul
          • Re: Implementation - per query variable setting GSoC projectSergei Golubchik12 Jul