From: Zardosht Kasheff Date: July 3 2009 3:09pm Subject: Re: feedback/review requested for fix to MySQL bug #45458 List-Archive: http://lists.mysql.com/internals/37079 Message-Id: <2f9663ba0907030809j636647b4w4faf64cfaa7670a9@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable In principle, I agree. The one thing I would like to point out here is that I think this is a feature that multiple storage engines may want to implement over time. I do not think of this as a storage-engine specific grammar extension. If multiple engines choose to implement this, they will need to duplicate the work of extending create table (and alter table) with the necessary attributes. I am not familiar with Sanja's patch, so maybe that is a cheap and acceptable cost. -Zardosht On Fri, Jul 3, 2009 at 10:09 AM, Sergei Golubchik wrote: > Hi, Zardosht! > > On Jun 25, Zardosht Kasheff wrote: >> >> This is a feature request that adds grammar for "clustering" indexes. >> Users can define an index to be clustering (include all of the columns >> in the index), and as a result, a flag is passed into the handler via >> a flag. It is up to the storage engine to properly implement it. >> Storage engines that choose to not implement it can simply ignore the >> flag. >> >> I am interested to hear feedback on this feature and patch. Here is >> the link: >> >> http://bugs.mysql.com/bug.php?id=3D45458 > > I don't have anything in particular against this patch, besides the fact > that I'd rather avoid extending the grammar indefinitely for every > storage engine. > > A generic approach would be better, something like Sanja's patch that > Monty was referring to. The goal of it was about allowing storage > engines to extend CREATE TABLE with arbitrary attributes - keyword=3Dvalu= e > pairs - per table, per column, and per index. Not as general as > arbitrary syntax extensions in arbitrary places, but also much simpler. > > The engine would only need to specify the names of the attributes and > their types (similar to my_getopt), like "PAGE_FILL_FACTOR, per table, > floating point, in the 0..1 range; CLUSTERED, boolean, per index" etc. > > Regards / Mit vielen Gr=FC=DFen, > Sergei > > -- > =A0 __ =A0___ =A0 =A0 ___ ____ =A0__ > =A0/ =A0|/ =A0/_ __/ __/ __ \/ / =A0 Sergei Golubchik > =A0/ /|_/ / // /\ \/ /_/ / /__ =A0Principal Software Engineer/Server Arch= itect > /_/ =A0/_/\_, /___/\___\_\___/ =A0Sun Microsystems GmbH, HRB M=FCnchen 16= 1028 > =A0 =A0 =A0 <___/ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0Sonnenallee 1, 85551= Kirchheim-Heimstetten > Gesch=E4ftsf=FChrer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel > Vorsitzender des Aufsichtsrates: Martin H=E4ring >