Re: MySql coding style: Request for deprecation of UPPERCASE typedefs

[Tor Didriksen]

On Wed, 01 Jul 2009 06:03:28 +0200, Alex Esterkin <aesterkin@stripped>  
wrote:

> Have you considered how much extra work and headache a change like
> this will bring to the community?  Evolution of particular features,
> functions, and files will become impossible to trace, numerous partner
> libraries will break, etc.
>
> Do you also plan on changing class names?  For example, rename THD
> into  Thd, rename sql_exchange into Sql_exchange, etc?
>

Please note that my proposal was only to deprecate the rule, no massive  
re-write.

-- didrik

> Regards,
> Alex Esterkin
>
> On Mon, Jun 22, 2009 at 9:02 AM, Tor Didriksen<Tor.Didriksen@stripped>  
> wrote:
>> hi
>>
>> "Structure types are typedef'ed to an all-upper-case identifier."
>> Can someone explain the reasoning behind this?
>> ALL_UPPERCASE_NAME says DANGEROUS_THIS_IS_A_MACRO to me, rather than
>> struct/class.
>>
>> typedef struct foo { ... } FOO;
>> Is legacy C-style, and does not belong in a C++ style guide (imho).
>>
>> Roy had an email about this:
>> http://lists.mysql.com/internals/36570
>> I could find no objections to his mail, the thread simply died.
>>
>> -- didrik
>>
>> --
>> MySQL Internals Mailing List
>> For list archives: http://lists.mysql.com/internals
>> To unsubscribe:
>>  http://lists.mysql.com/internals?unsub=1
>>
>>