From: Michael Widenius Date: June 30 2009 9:23pm Subject: Re: MySql coding style: Request for deprecation of UPPERCASE typedefs List-Archive: http://lists.mysql.com/internals/37048 Message-Id: <19018.33349.380954.840972@narttu.askmonty.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi! >>>>> "Jay" == Jay Pipes writes: >> Actually, it also gives you fewer errors and makes it easier to start >> coding a new project file (this is from experience with the MySQL projects) Jay> You ARE kidding, right? When is the last time you counted the number of Jay> warnings emitted during a standard build of MySQL? When I handled the builds, we didn't have a single warnings in the MySQL code. (We did have some in readline, but that's not code we are responsible of). If you look at MariaDB, there is no warning in any MariaDB related code. Jay> By splitting class declarations into appropriately-named headers, and Jay> only including in an implementation file the headers needed for Jay> compiling the code in that file, you *make the code and file structure Jay> clearer*. This clarity enables more people to become familiar with how Jay> the classes, files and directories are structured simply by looking at Jay> the file organization. If you want proof of this, ask any Drizzle Jay> contributor who has worked on both the MySQL and the Drizzle code bases. It's always a difference to ask someone that is new to a code base and someone that has worked with the code for a long time. This has however nothing to with my statement. >> just one) and there is lost of examples, so this isn't a big thing. >> >> Allowing things to be included in any order, will force you to have >> massive include directives in the include files and is an even worse >> practice and harder to maintain. Jay> When you state things like "even worse practice" and "harder to Jay> maintain", you are not giving any hard evidence to back up those claims. The fact that I have worked with the MySQL code x2 times longer than anyone else is does give me a lot of experience of the code that I can use to stand up my claims. Jay> This makes it look like you are just not willing to acknowledge a Jay> difference of opinion in these long-standing issues in the MySQL code Jay> base. This is a shame, Monty. Jay, please grow up. Regards, Monty