| List: | Internals | « Previous MessageNext Message » | |
| From: | Sergei Golubchik | Date: | June 22 2009 2:59pm |
| Subject: | Re: MySql coding style: Request for deprecation of UPPERCASE typedefs | ||
| View as plain text | |||
Hi, Tor! On Jun 22, Tor Didriksen wrote: > hi > > "Structure types are typedef'ed to an all-upper-case identifier." > Can someone explain the reasoning behind this? > ALL_UPPERCASE_NAME says DANGEROUS_THIS_IS_A_MACRO to me, rather than > struct/class. > > typedef struct foo { ... } FOO; > Is legacy C-style, and does not belong in a C++ style guide (imho). MySQL isn't all C++. What about the reasoning of avoiding two completely different coding styles in different parts of the server ? Regards / Mit vielen Grüßen, Sergei -- __ ___ ___ ____ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik <serg@stripped> / /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect /_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028 <___/ Sonnenallee 1, 85551 Kirchheim-Heimstetten Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin Häring
