List:Internals« Previous MessageNext Message »
From:Michael Widenius Date:April 17 2009 4:48pm
Subject:Re: [patch] plugin build process improvements
View as plain text  
Hi!

>>>>> "Hartmut" == Hartmut Holzgraefe <Hartmut.Holzgraefe@stripped>
> writes:

Hartmut> Michael Widenius wrote:
>> The build scripts, especially the debug ones, doesn't use the
>> --full-debug option but instead uses instead exact defines to get a
>> finer control.  As long as this is the case we should NOT remove the
>> defines from these scripts.

Hartmut> at least BUILD/compile-pentium-debug-max does ...

Yes, we can remove the usage of defines from some script. My point was
that we shouldn't try to remove all defines and make them configure
options.

Hartmut> And add some configure options for things like EXTRA_DEBUG instead
Hartmut> of controlling these via manually adding -D options to CFLAGS to
Hartmut> controll these only?

>> May be more work than what's it's worth and will make the build script
>> harder to read as you get an extra mapping between the source and the
>> script.

Hartmut> the problem i actually ran into when building UDFs/plugins was that
Hartmut> for the things that were set by extending CFLAGS and friends only
Hartmut> it is hard to determine whether the flag was set when the server
Hartmut> was compiled or not, at least for those plugin types that should
Hartmut> only need public header files and not the full server code.

I agree that flags that affects header files should have configure
options.

In addition, all important flags should be handled by the mysql_config
script.

<cut>

Regards,
Monty

Thread
[patch] plugin build process improvementsAntony Dovgal18 Mar
  • Re: [patch] plugin build process improvementsChad MILLER18 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal18 Mar
      • Re: [patch] plugin build process improvementsSergei Golubchik18 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal19 Mar
    • Re: [patch] plugin build process improvementsLenz Grimmer24 Mar
  • Re: [patch] plugin build process improvementsSergei Golubchik19 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal19 Mar
      • Re: [patch] plugin build process improvementsSergei Golubchik19 Mar
        • Re: [patch] plugin build process improvementsAntony Dovgal20 Mar
          • Re: [patch] plugin build process improvementsMichael Widenius22 Mar
  • Re: [patch] plugin build process improvementsHartmut Holzgraefe19 Mar
    • Re: [patch] plugin build process improvementsMichael Widenius22 Mar
      • Re: [patch] plugin build process improvementsHartmut Holzgraefe23 Mar
        • Re: [patch] plugin build process improvementsMichael Widenius17 Apr
  • Re: [patch] plugin build process improvementsChad MILLER19 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal20 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
      • Re: [patch] plugin build process improvementsChad MILLER3 Apr
        • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
          • Re: [patch] plugin build process improvementsDavi Arnaut3 Apr
            • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
              • Re: [patch] plugin build process improvementsBrian Aker3 Apr
                • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
                  • Re: [patch] plugin build process improvementsKonstantin Osipov3 Apr
                    • Re: [patch] plugin build process improvementsAntony Dovgal4 Apr
                      • Re: [patch] plugin build process improvementsSergei Golubchik4 Apr
                        • Re: [patch] plugin build process improvementsAntony Dovgal4 Apr
                          • Re: [patch] plugin build process improvementsSergei Golubchik14 Apr
                            • Re: [patch] plugin build process improvementsAntony Dovgal14 Apr
                            • Re: [patch] plugin build process improvementsAntony Dovgal7 May
                              • Re: [patch] plugin build process improvementsSergei Golubchik7 May
                                • Re: [patch] plugin build process improvementsAntony Dovgal7 May
              • Re: [patch] plugin build process improvementsDavi Arnaut3 Apr
                • Re: [patch] plugin build process improvementsMats Kindahl3 Apr
          • Re: [patch] plugin build process improvementsChad MILLER3 Apr
            • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
            • Re: [patch] plugin build process improvementsChad MILLER3 Apr
          • Re: [patch] plugin build process improvementsSergei Golubchik3 Apr
  • re: [patch] plugin build process improvementsMichael Widenius22 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal22 Mar