Hi!
>>>>> "Hartmut" == Hartmut Holzgraefe <Hartmut.Holzgraefe@stripped>
> writes:
Hartmut> Michael Widenius wrote:
>> The build scripts, especially the debug ones, doesn't use the
>> --full-debug option but instead uses instead exact defines to get a
>> finer control. As long as this is the case we should NOT remove the
>> defines from these scripts.
Hartmut> at least BUILD/compile-pentium-debug-max does ...
Yes, we can remove the usage of defines from some script. My point was
that we shouldn't try to remove all defines and make them configure
options.
Hartmut> And add some configure options for things like EXTRA_DEBUG instead
Hartmut> of controlling these via manually adding -D options to CFLAGS to
Hartmut> controll these only?
>> May be more work than what's it's worth and will make the build script
>> harder to read as you get an extra mapping between the source and the
>> script.
Hartmut> the problem i actually ran into when building UDFs/plugins was that
Hartmut> for the things that were set by extending CFLAGS and friends only
Hartmut> it is hard to determine whether the flag was set when the server
Hartmut> was compiled or not, at least for those plugin types that should
Hartmut> only need public header files and not the full server code.
I agree that flags that affects header files should have configure
options.
In addition, all important flags should be handled by the mysql_config
script.
<cut>
Regards,
Monty
