List:Internals« Previous MessageNext Message »
From:Davi Arnaut Date:April 3 2009 2:41pm
Subject:Re: [patch] plugin build process improvements
View as plain text  
On 4/3/09 11:10 AM, Antony Dovgal wrote:
> On 03.04.2009 17:44, Davi Arnaut wrote:
>> There needs to be a separation between private (to the server) and
>> public (exposed to the plugins) structures, we can't just expose all of
>> then without creating a mess as it might later hinder our ability to
>> modify or fix internal structures without causing havoc for the plugins.
>
> I understand you concerns.
> If you are fully confident that some header file must not and can not be used by
> any plugins - fine, don't install it. Can you define such files?
>
> As far as I understand (correct me if I'm wrong) both private and public structs
> are defined in the same headers, so separating them would require much bigger
> patch than the proposed one.

You are correct.

>> We should be looking at this on a case-by-case basis. Or we decide to
>> not guarantee stability on the exposed structures. What do you prefer?
>
> I truly believe that any plugins doing weird things with structures they shouldn't
> be using at all do deserve to be broken.
>
> What did you mean by case-by-case basis?

We should analyze every little part of the API that we make public.

> I can try to figure out which headers are required to build my plugin, but others
> may
> need something I don't use, which means the problem would be still there, just hidden
> for some time.

Could you list which pieces (structures, functions, etc) of the server 
that you need to use from your plugin? Or its more a matter circular 
dependency? I think we need to sched some light on the specific problem..

-- Davi Arnaut

Thread
[patch] plugin build process improvementsAntony Dovgal18 Mar
  • Re: [patch] plugin build process improvementsChad MILLER18 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal18 Mar
      • Re: [patch] plugin build process improvementsSergei Golubchik18 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal19 Mar
    • Re: [patch] plugin build process improvementsLenz Grimmer24 Mar
  • Re: [patch] plugin build process improvementsSergei Golubchik19 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal19 Mar
      • Re: [patch] plugin build process improvementsSergei Golubchik19 Mar
        • Re: [patch] plugin build process improvementsAntony Dovgal20 Mar
          • Re: [patch] plugin build process improvementsMichael Widenius22 Mar
  • Re: [patch] plugin build process improvementsHartmut Holzgraefe19 Mar
    • Re: [patch] plugin build process improvementsMichael Widenius22 Mar
      • Re: [patch] plugin build process improvementsHartmut Holzgraefe23 Mar
        • Re: [patch] plugin build process improvementsMichael Widenius17 Apr
  • Re: [patch] plugin build process improvementsChad MILLER19 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal20 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
      • Re: [patch] plugin build process improvementsChad MILLER3 Apr
        • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
          • Re: [patch] plugin build process improvementsDavi Arnaut3 Apr
            • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
              • Re: [patch] plugin build process improvementsBrian Aker3 Apr
                • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
                  • Re: [patch] plugin build process improvementsKonstantin Osipov3 Apr
                    • Re: [patch] plugin build process improvementsAntony Dovgal4 Apr
                      • Re: [patch] plugin build process improvementsSergei Golubchik4 Apr
                        • Re: [patch] plugin build process improvementsAntony Dovgal4 Apr
                          • Re: [patch] plugin build process improvementsSergei Golubchik14 Apr
                            • Re: [patch] plugin build process improvementsAntony Dovgal14 Apr
                            • Re: [patch] plugin build process improvementsAntony Dovgal7 May
                              • Re: [patch] plugin build process improvementsSergei Golubchik7 May
                                • Re: [patch] plugin build process improvementsAntony Dovgal7 May
              • Re: [patch] plugin build process improvementsDavi Arnaut3 Apr
                • Re: [patch] plugin build process improvementsMats Kindahl3 Apr
          • Re: [patch] plugin build process improvementsChad MILLER3 Apr
            • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
            • Re: [patch] plugin build process improvementsChad MILLER3 Apr
          • Re: [patch] plugin build process improvementsSergei Golubchik3 Apr
  • re: [patch] plugin build process improvementsMichael Widenius22 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal22 Mar