List:Internals« Previous MessageNext Message »
From:Chad MILLER Date:April 3 2009 2:07pm
Subject:Re: [patch] plugin build process improvements
View as plain text  
On 04/03/2009 09:26 AM, Antony Dovgal wrote:
> On 03.04.2009 17:17, Chad MILLER wrote:
>> Not yet, sorry.  I'm almost certain that there are structures that
>> really should be hidden, but I am not enough conversant in our
>> storage-engine Best Practices to know what should be exposed.
>>
>> It's funny psycologically, that if you had submitted a patch that
>> included all but one file, I would not be so troubled by it, regardless
>> of its correctness.  But *all* headers, that really bothers me.
>
> I'd be happy to modify the patch, but I just don't know what (and why) you'd like to
> 'hide'.
>
> Also, I believe that any structures/defines/whatever used in MySQL *theoretically*
> might be
> (or will be) useful for the plugins; so if you 'hide' them now, you'll have to
> 'unhide' them later.

Even in a general API, we have much that we insist on being able to 
change at any time without having to consider the risk of breaking 
anything.  We're trying to define a *plugin* interface, which is even 
more discrete and discreet than a general API.

As a moral developer, I think that exporting headers suggests I'm 
willing to promise that you're allowed to use them without fear.  I'm 
not willing to do that for *many* of these files.  If I delete one 
tomorrow, it shouldn't anyone's code.

- chad
Thread
[patch] plugin build process improvementsAntony Dovgal18 Mar
  • Re: [patch] plugin build process improvementsChad MILLER18 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal18 Mar
      • Re: [patch] plugin build process improvementsSergei Golubchik18 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal19 Mar
    • Re: [patch] plugin build process improvementsLenz Grimmer24 Mar
  • Re: [patch] plugin build process improvementsSergei Golubchik19 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal19 Mar
      • Re: [patch] plugin build process improvementsSergei Golubchik19 Mar
        • Re: [patch] plugin build process improvementsAntony Dovgal20 Mar
          • Re: [patch] plugin build process improvementsMichael Widenius22 Mar
  • Re: [patch] plugin build process improvementsHartmut Holzgraefe19 Mar
    • Re: [patch] plugin build process improvementsMichael Widenius22 Mar
      • Re: [patch] plugin build process improvementsHartmut Holzgraefe23 Mar
        • Re: [patch] plugin build process improvementsMichael Widenius17 Apr
  • Re: [patch] plugin build process improvementsChad MILLER19 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal20 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
      • Re: [patch] plugin build process improvementsChad MILLER3 Apr
        • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
          • Re: [patch] plugin build process improvementsDavi Arnaut3 Apr
            • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
              • Re: [patch] plugin build process improvementsBrian Aker3 Apr
                • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
                  • Re: [patch] plugin build process improvementsKonstantin Osipov3 Apr
                    • Re: [patch] plugin build process improvementsAntony Dovgal4 Apr
                      • Re: [patch] plugin build process improvementsSergei Golubchik4 Apr
                        • Re: [patch] plugin build process improvementsAntony Dovgal4 Apr
                          • Re: [patch] plugin build process improvementsSergei Golubchik14 Apr
                            • Re: [patch] plugin build process improvementsAntony Dovgal14 Apr
                            • Re: [patch] plugin build process improvementsAntony Dovgal7 May
                              • Re: [patch] plugin build process improvementsSergei Golubchik7 May
                                • Re: [patch] plugin build process improvementsAntony Dovgal7 May
              • Re: [patch] plugin build process improvementsDavi Arnaut3 Apr
                • Re: [patch] plugin build process improvementsMats Kindahl3 Apr
          • Re: [patch] plugin build process improvementsChad MILLER3 Apr
            • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
            • Re: [patch] plugin build process improvementsChad MILLER3 Apr
          • Re: [patch] plugin build process improvementsSergei Golubchik3 Apr
  • re: [patch] plugin build process improvementsMichael Widenius22 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal22 Mar