List:Internals« Previous MessageNext Message »
From:Hartmut Holzgraefe Date:March 23 2009 7:33am
Subject:Re: [patch] plugin build process improvements
View as plain text  
Michael Widenius wrote:

> The build scripts, especially the debug ones, doesn't use the
> --full-debug option but instead uses instead exact defines to get a
> finer control.  As long as this is the case we should NOT remove the
> defines from these scripts.

at least BUILD/compile-pentium-debug-max does ...

> Hartmut> And add some configure options for things like EXTRA_DEBUG instead
> Hartmut> of controlling these via manually adding -D options to CFLAGS to
> Hartmut> controll these only?
> 
> May be more work than what's it's worth and will make the build script
> harder to read as you get an extra mapping between the source and the
> script.

the problem i actually ran into when building UDFs/plugins was that
for the things that were set by extending CFLAGS and friends only
it is hard to determine whether the flag was set when the server
was compiled or not, at least for those plugin types that should
only need public header files and not the full server code.

I ran into issues with that with either SAFEMALLOC or SAFE_MUTEX
(or both), so right now i have the following snippet in my code
generator for plugins:

   // TODO configure should take care of this
   #ifdef DBUG_ON
   #define SAFEMALLOC
   #define PEDANTIC_SAFEMALLOC
   #define SAFE_MUTEX
   #endif

simply assuming that all debug servers were built with these
options.

Thinking again just having AC_DEFINE entries for these (and
EXTRA_DEBUG) would be sufficient though so that these settings
could just be taken from the public my_config.h instead of
guessing them.

'Real' configure options would still be nice so that the
existence of these options is documented in "configure --help"
output though ...

-- 
Hartmut Holzgraefe, MySQL Regional Support Manager, EMEA

Don't Miss the 2009 MySQL User's Conference: http://mysqlconf.com

Sun Microsystems GmbH, Sonnenallee 1, 85551 Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB161028
Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering
Thread
[patch] plugin build process improvementsAntony Dovgal18 Mar
  • Re: [patch] plugin build process improvementsChad MILLER18 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal18 Mar
      • Re: [patch] plugin build process improvementsSergei Golubchik18 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal19 Mar
    • Re: [patch] plugin build process improvementsLenz Grimmer24 Mar
  • Re: [patch] plugin build process improvementsSergei Golubchik19 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal19 Mar
      • Re: [patch] plugin build process improvementsSergei Golubchik19 Mar
        • Re: [patch] plugin build process improvementsAntony Dovgal20 Mar
          • Re: [patch] plugin build process improvementsMichael Widenius22 Mar
  • Re: [patch] plugin build process improvementsHartmut Holzgraefe19 Mar
    • Re: [patch] plugin build process improvementsMichael Widenius22 Mar
      • Re: [patch] plugin build process improvementsHartmut Holzgraefe23 Mar
        • Re: [patch] plugin build process improvementsMichael Widenius17 Apr
  • Re: [patch] plugin build process improvementsChad MILLER19 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal20 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
      • Re: [patch] plugin build process improvementsChad MILLER3 Apr
        • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
          • Re: [patch] plugin build process improvementsDavi Arnaut3 Apr
            • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
              • Re: [patch] plugin build process improvementsBrian Aker3 Apr
                • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
                  • Re: [patch] plugin build process improvementsKonstantin Osipov3 Apr
                    • Re: [patch] plugin build process improvementsAntony Dovgal4 Apr
                      • Re: [patch] plugin build process improvementsSergei Golubchik4 Apr
                        • Re: [patch] plugin build process improvementsAntony Dovgal4 Apr
                          • Re: [patch] plugin build process improvementsSergei Golubchik14 Apr
                            • Re: [patch] plugin build process improvementsAntony Dovgal14 Apr
                            • Re: [patch] plugin build process improvementsAntony Dovgal7 May
                              • Re: [patch] plugin build process improvementsSergei Golubchik7 May
                                • Re: [patch] plugin build process improvementsAntony Dovgal7 May
              • Re: [patch] plugin build process improvementsDavi Arnaut3 Apr
                • Re: [patch] plugin build process improvementsMats Kindahl3 Apr
          • Re: [patch] plugin build process improvementsChad MILLER3 Apr
            • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
            • Re: [patch] plugin build process improvementsChad MILLER3 Apr
          • Re: [patch] plugin build process improvementsSergei Golubchik3 Apr
  • re: [patch] plugin build process improvementsMichael Widenius22 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal22 Mar