From: Michael Widenius
Date: March 22 2009 11:23am
Subject: Re: [patch] plugin build process improvements
List-Archive: http://lists.mysql.com/internals/36459
Message-Id: <18886.8126.667478.154858@narttu.askmonty.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit


Hi!

>>>>> "Hartmut" == Hartmut Holzgraefe <Hartmut.Holzgraefe@stripped> writes:

Hartmut> Antony Dovgal wrote:
>> Patch #2 (mysql_defines.h) fixes another problem: if MySQL server has been built with --with-debug option, 
>> it uses SAFE_MUTEX (and SAFEMALLOC for "full" debug), but these defines are nowhere to be found, 
>> hence one needs to add them manually in order to build a working plugin (there are no compile errors, 
>> just random runtime problems because of different structure size).
>> The patch adds these defines to config.h (and my_config.h).

Hartmut> while we're on it we should also remove the addition of SADE_MUTEX
Hartmut> and SAFEMALLOC defines in BUILD/compile-*-debug* build scripts as
Hartmut> these are redundant anyway?

The build scripts, especially the debug ones, doesn't use the
--full-debug option but instead uses instead exact defines to get a
finer control.  As long as this is the case we should NOT remove the
defines from these scripts.

Hartmut> And add some configure options for things like EXTRA_DEBUG instead
Hartmut> of controlling these via manually adding -D options to CFLAGS to
Hartmut> controll these only?

May be more work than what's it's worth and will make the build script
harder to read as you get an extra mapping between the source and the
script.

Regards,
Monty