List:Internals« Previous MessageNext Message »
From:Michael Widenius Date:March 22 2009 11:23am
Subject:Re: [patch] plugin build process improvements
View as plain text  
Hi!

>>>>> "Hartmut" == Hartmut Holzgraefe <Hartmut.Holzgraefe@stripped>
> writes:

Hartmut> Antony Dovgal wrote:
>> Patch #2 (mysql_defines.h) fixes another problem: if MySQL server has been built
> with --with-debug option, 
>> it uses SAFE_MUTEX (and SAFEMALLOC for "full" debug), but these defines are
> nowhere to be found, 
>> hence one needs to add them manually in order to build a working plugin (there
> are no compile errors, 
>> just random runtime problems because of different structure size).
>> The patch adds these defines to config.h (and my_config.h).

Hartmut> while we're on it we should also remove the addition of SADE_MUTEX
Hartmut> and SAFEMALLOC defines in BUILD/compile-*-debug* build scripts as
Hartmut> these are redundant anyway?

The build scripts, especially the debug ones, doesn't use the
--full-debug option but instead uses instead exact defines to get a
finer control.  As long as this is the case we should NOT remove the
defines from these scripts.

Hartmut> And add some configure options for things like EXTRA_DEBUG instead
Hartmut> of controlling these via manually adding -D options to CFLAGS to
Hartmut> controll these only?

May be more work than what's it's worth and will make the build script
harder to read as you get an extra mapping between the source and the
script.

Regards,
Monty
Thread
[patch] plugin build process improvementsAntony Dovgal18 Mar
  • Re: [patch] plugin build process improvementsChad MILLER18 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal18 Mar
      • Re: [patch] plugin build process improvementsSergei Golubchik18 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal19 Mar
    • Re: [patch] plugin build process improvementsLenz Grimmer24 Mar
  • Re: [patch] plugin build process improvementsSergei Golubchik19 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal19 Mar
      • Re: [patch] plugin build process improvementsSergei Golubchik19 Mar
        • Re: [patch] plugin build process improvementsAntony Dovgal20 Mar
          • Re: [patch] plugin build process improvementsMichael Widenius22 Mar
  • Re: [patch] plugin build process improvementsHartmut Holzgraefe19 Mar
    • Re: [patch] plugin build process improvementsMichael Widenius22 Mar
      • Re: [patch] plugin build process improvementsHartmut Holzgraefe23 Mar
        • Re: [patch] plugin build process improvementsMichael Widenius17 Apr
  • Re: [patch] plugin build process improvementsChad MILLER19 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal20 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
      • Re: [patch] plugin build process improvementsChad MILLER3 Apr
        • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
          • Re: [patch] plugin build process improvementsDavi Arnaut3 Apr
            • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
              • Re: [patch] plugin build process improvementsBrian Aker3 Apr
                • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
                  • Re: [patch] plugin build process improvementsKonstantin Osipov3 Apr
                    • Re: [patch] plugin build process improvementsAntony Dovgal4 Apr
                      • Re: [patch] plugin build process improvementsSergei Golubchik4 Apr
                        • Re: [patch] plugin build process improvementsAntony Dovgal4 Apr
                          • Re: [patch] plugin build process improvementsSergei Golubchik14 Apr
                            • Re: [patch] plugin build process improvementsAntony Dovgal14 Apr
                            • Re: [patch] plugin build process improvementsAntony Dovgal7 May
                              • Re: [patch] plugin build process improvementsSergei Golubchik7 May
                                • Re: [patch] plugin build process improvementsAntony Dovgal7 May
              • Re: [patch] plugin build process improvementsDavi Arnaut3 Apr
                • Re: [patch] plugin build process improvementsMats Kindahl3 Apr
          • Re: [patch] plugin build process improvementsChad MILLER3 Apr
            • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
            • Re: [patch] plugin build process improvementsChad MILLER3 Apr
          • Re: [patch] plugin build process improvementsSergei Golubchik3 Apr
  • re: [patch] plugin build process improvementsMichael Widenius22 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal22 Mar