From: Michael Widenius Date: March 22 2009 10:36am Subject: re: [patch] plugin build process improvements List-Archive: http://lists.mysql.com/internals/36456 Message-Id: <18886.5287.317169.469491@narttu.askmonty.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi! >>>>> "Antony" == Antony Dovgal writes: Antony> Hello all. Antony> At the moment MySQL plugin process is overly complicated - in order to build a plugin one must perform the following actions: Antony> 1) fetch MySQL sources Antony> 2) run `./configure` Antony> 3) run `make`, as my_config.h is created by make, not ./configure. Antony> Patch #1 (mysql_my_config.h.diff) addresses this problem by eliminating step #3. Antony> Patch #2 (mysql_defines.h) fixes another problem: if MySQL server has been built with --with-debug option, Antony> it uses SAFE_MUTEX (and SAFEMALLOC for "full" debug), but these defines are nowhere to be found, Antony> hence one needs to add them manually in order to build a working plugin (there are no compile errors, Antony> just random runtime problems because of different structure size). Antony> The patch adds these defines to config.h (and my_config.h). Antony> Please review attached patches. Antony> You can also find them here: Antony> http://dev.daylessday.org/diff/mysql_my_config.h.diff Antony> http://dev.daylessday.org/diff/mysql_defines.diff Thanks for the patches. I will add these to MariaDB at once! http://askmonty.org/wiki/index.php/MariaDB Regards, Monty