List:Internals« Previous MessageNext Message »
From:Michael Widenius Date:March 22 2009 10:36am
Subject:re: [patch] plugin build process improvements
View as plain text  
Hi!

>>>>> "Antony" == Antony Dovgal <tony@stripped> writes:

Antony> Hello all.
Antony> At the moment MySQL plugin process is overly complicated - in order to build a
> plugin one must perform the following actions:
Antony> 1) fetch MySQL sources
Antony> 2) run `./configure`
Antony> 3) run `make`, as my_config.h is created by make, not ./configure.

Antony> Patch #1 (mysql_my_config.h.diff) addresses this problem by eliminating step
> #3.

Antony> Patch #2 (mysql_defines.h) fixes another problem: if MySQL server has been
> built with --with-debug option, 
Antony> it uses SAFE_MUTEX (and SAFEMALLOC for "full" debug), but these defines are
> nowhere to be found, 
Antony> hence one needs to add them manually in order to build a working plugin (there
> are no compile errors, 
Antony> just random runtime problems because of different structure size).
Antony> The patch adds these defines to config.h (and my_config.h).

Antony> Please review attached patches.
Antony> You can also find them here: 
Antony> http://dev.daylessday.org/diff/mysql_my_config.h.diff
Antony> http://dev.daylessday.org/diff/mysql_defines.diff

Thanks for the patches. I will add these to MariaDB at once!
http://askmonty.org/wiki/index.php/MariaDB

Regards,
Monty
Thread
[patch] plugin build process improvementsAntony Dovgal18 Mar
  • Re: [patch] plugin build process improvementsChad MILLER18 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal18 Mar
      • Re: [patch] plugin build process improvementsSergei Golubchik18 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal19 Mar
    • Re: [patch] plugin build process improvementsLenz Grimmer24 Mar
  • Re: [patch] plugin build process improvementsSergei Golubchik19 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal19 Mar
      • Re: [patch] plugin build process improvementsSergei Golubchik19 Mar
        • Re: [patch] plugin build process improvementsAntony Dovgal20 Mar
          • Re: [patch] plugin build process improvementsMichael Widenius22 Mar
  • Re: [patch] plugin build process improvementsHartmut Holzgraefe19 Mar
    • Re: [patch] plugin build process improvementsMichael Widenius22 Mar
      • Re: [patch] plugin build process improvementsHartmut Holzgraefe23 Mar
        • Re: [patch] plugin build process improvementsMichael Widenius17 Apr
  • Re: [patch] plugin build process improvementsChad MILLER19 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal20 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
      • Re: [patch] plugin build process improvementsChad MILLER3 Apr
        • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
          • Re: [patch] plugin build process improvementsDavi Arnaut3 Apr
            • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
              • Re: [patch] plugin build process improvementsBrian Aker3 Apr
                • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
                  • Re: [patch] plugin build process improvementsKonstantin Osipov3 Apr
                    • Re: [patch] plugin build process improvementsAntony Dovgal4 Apr
                      • Re: [patch] plugin build process improvementsSergei Golubchik4 Apr
                        • Re: [patch] plugin build process improvementsAntony Dovgal4 Apr
                          • Re: [patch] plugin build process improvementsSergei Golubchik14 Apr
                            • Re: [patch] plugin build process improvementsAntony Dovgal14 Apr
                            • Re: [patch] plugin build process improvementsAntony Dovgal7 May
                              • Re: [patch] plugin build process improvementsSergei Golubchik7 May
                                • Re: [patch] plugin build process improvementsAntony Dovgal7 May
              • Re: [patch] plugin build process improvementsDavi Arnaut3 Apr
                • Re: [patch] plugin build process improvementsMats Kindahl3 Apr
          • Re: [patch] plugin build process improvementsChad MILLER3 Apr
            • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
            • Re: [patch] plugin build process improvementsChad MILLER3 Apr
          • Re: [patch] plugin build process improvementsSergei Golubchik3 Apr
  • re: [patch] plugin build process improvementsMichael Widenius22 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal22 Mar