List:Internals« Previous MessageNext Message »
From:Chad MILLER Date:March 18 2009 12:35pm
Subject:Re: [patch] plugin build process improvements
View as plain text  
On 03/18/2009 07:30 AM, Antony Dovgal wrote:
> Hello all.
>
> At the moment MySQL plugin process is overly complicated - in order to build a plugin
> one must perform the following actions:
> 1) fetch MySQL sources
> 2) run `./configure`
> 3) run `make`, as my_config.h is created by make, not ./configure.
>
> Patch #1 (mysql_my_config.h.diff) addresses this problem by eliminating step #3.
>
> Patch #2 (mysql_defines.h) fixes another problem: if MySQL server has been built with
> --with-debug option,
> it uses SAFE_MUTEX (and SAFEMALLOC for "full" debug), but these defines are nowhere
> to be found,
> hence one needs to add them manually in order to build a working plugin (there are no
> compile errors,
> just random runtime problems because of different structure size).
> The patch adds these defines to config.h (and my_config.h).
>
> Please review attached patches.
> You can also find them here:
> http://dev.daylessday.org/diff/mysql_my_config.h.diff
> http://dev.daylessday.org/diff/mysql_defines.diff

Both are very sensible.  Thank you.

Since these are so small, you don't (AFAIK, IANAL) need to sign our 
contributor agreement, but if you might contribute in the future you 
might like to do so now.

http://www.sun.com/software/opensource/contributor_agreement.jsp

Thank you, Antony.

- chad
Thread
[patch] plugin build process improvementsAntony Dovgal18 Mar
  • Re: [patch] plugin build process improvementsChad MILLER18 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal18 Mar
      • Re: [patch] plugin build process improvementsSergei Golubchik18 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal19 Mar
    • Re: [patch] plugin build process improvementsLenz Grimmer24 Mar
  • Re: [patch] plugin build process improvementsSergei Golubchik19 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal19 Mar
      • Re: [patch] plugin build process improvementsSergei Golubchik19 Mar
        • Re: [patch] plugin build process improvementsAntony Dovgal20 Mar
          • Re: [patch] plugin build process improvementsMichael Widenius22 Mar
  • Re: [patch] plugin build process improvementsHartmut Holzgraefe19 Mar
    • Re: [patch] plugin build process improvementsMichael Widenius22 Mar
      • Re: [patch] plugin build process improvementsHartmut Holzgraefe23 Mar
        • Re: [patch] plugin build process improvementsMichael Widenius17 Apr
  • Re: [patch] plugin build process improvementsChad MILLER19 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal20 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
      • Re: [patch] plugin build process improvementsChad MILLER3 Apr
        • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
          • Re: [patch] plugin build process improvementsDavi Arnaut3 Apr
            • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
              • Re: [patch] plugin build process improvementsBrian Aker3 Apr
                • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
                  • Re: [patch] plugin build process improvementsKonstantin Osipov3 Apr
                    • Re: [patch] plugin build process improvementsAntony Dovgal4 Apr
                      • Re: [patch] plugin build process improvementsSergei Golubchik4 Apr
                        • Re: [patch] plugin build process improvementsAntony Dovgal4 Apr
                          • Re: [patch] plugin build process improvementsSergei Golubchik14 Apr
                            • Re: [patch] plugin build process improvementsAntony Dovgal14 Apr
                            • Re: [patch] plugin build process improvementsAntony Dovgal7 May
                              • Re: [patch] plugin build process improvementsSergei Golubchik7 May
                                • Re: [patch] plugin build process improvementsAntony Dovgal7 May
              • Re: [patch] plugin build process improvementsDavi Arnaut3 Apr
                • Re: [patch] plugin build process improvementsMats Kindahl3 Apr
          • Re: [patch] plugin build process improvementsChad MILLER3 Apr
            • Re: [patch] plugin build process improvementsAntony Dovgal3 Apr
            • Re: [patch] plugin build process improvementsChad MILLER3 Apr
          • Re: [patch] plugin build process improvementsSergei Golubchik3 Apr
  • re: [patch] plugin build process improvementsMichael Widenius22 Mar
    • Re: [patch] plugin build process improvementsAntony Dovgal22 Mar