From: Michael Widenius Date: March 8 2009 1:44pm Subject: Re: MySQL University Session: Good Coding Style follow up List-Archive: http://lists.mysql.com/internals/36366 Message-Id: <18867.52129.502914.213461@narttu.askmonty.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit hi! >>>>> "Konstantin" == Konstantin Osipov writes: Konstantin> * Jonas Oreland [09/03/05 22:36]: >> linux kernel has a concept (that I would like that cluster also had), >> that I think might also work for mysqld >> >> they also prefer not to change *all* code in one go due to merging, history etc. >> but they have a perl-script called "check-patch.pl" that verifies that all new code >> that is added is conforming to code standard. >> >> maybe something to look at... Konstantin> We tried in 2005 to write an indent rule to check that. Konstantin> Unfortunately, our style doesn't allow fully automated checking. There is nothing in our rules that wouldn't allow for fully automated checking or fixing. The problem is what we used indent as a base and it's not the perfect way to get something that works in all casee. Konstantin> So in order to have such script, we need to be able to change the Konstantin> style. Which brings us back to the question about the procedure Konstantin> for accepting change. What is it that you think in the current coding style that can't be enforced / fixed with a script ? Regards, Monty