On 3/5/09 4:18 PM, Konstantin Osipov wrote:
> * Davi Arnaut<Davi.Arnaut@stripped> [09/03/05 20:35]:
>> This is something that reviewers should be looking at. Patches shouldn't
>> be approved if they don't follow the coding style.
>
> Yes, I agree, I think all agree about that. Does the fact that
> we can enforce a coding style by code reviews mean that we don't
> need to change and improve what we have? That's what I'm
> trying to draw attention to.
>
> And since you brought up the subject, here's just a recent example
> that got in (you probably recognize the author and the reviewer):
>
> bool
> -Silence_deprecated_warning::
> -handle_error(THD *thd, MYSQL_ERROR::enum_warning_level level,
> - uint sql_errno, const char *message)
> +Silence_deprecated_warning::handle_condition(
> + THD *,
> + uint sql_errno,
> + const char*,
> + MYSQL_ERROR::enum_warning_level level,
> + const char*,
> + MYSQL_ERROR ** cond_hdl)
> {
> + *cond_hdl= NULL;
>
Guilty as charged, but unfortunately not all developers are conscious
that the coding style must be followed. If we make this a whole
team/community effort, i guess some would start to accept it.
