List:Internals« Previous MessageNext Message »
From:Jeff Licquia Date:June 29 2007 7:13pm
Subject:Re: [PATCH] Proposed patch for #29274: enable LSB-compliant builds
of MySQL
View as plain text  
Hmm, just saw this.  Sorry for the late reply.

On Fri, 2007-06-22 at 08:49 +0000, Stewart Smith wrote:
> On Thu, 2007-06-21 at 11:47 -0400, Jeff Licquia wrote:
> > I've attached our proposed patch for enabling MySQL to be built using
> > the Linux Standard Base (LSB) SDK, resulting in LSB-compliant
> > binaries.
> 
> >  - getdtablesize() is not available, so I have provided a local
> > replacement.  Since getdtablesize() is defined in terms of sysconf()
> > and
> > getrlimit(), it should be an exact equivalent.
> 
> hrrm... where isn't it always available?

In the LSB.  The theory is that getdtablesize() isn't in POSIX and is
defined, where it exists, by reference to other facilities that are in
POSIX.

> Granted, we only care about cpcd on test systems... it's not for
> deployment (unless you're casually insane).

If you want to drop your use of getdtablesize() entirely, we're of
course not opposed to that.  Or, if the patch needs reworking because
stuff is in the wrong place.

Thread
[PATCH] Proposed patch for #29274: enable LSB-compliant builds ofMySQLJeff Licquia21 Jun
  • Re: [PATCH] Proposed patch for #29274: enable LSB-compliant buildsof MySQLStewart Smith22 Jun
    • Re: [PATCH] Proposed patch for #29274: enable LSB-compliant buildsof MySQLJeff Licquia29 Jun
  • Re: [PATCH] Proposed patch for #29274: enable LSB-compliant builds of MySQLChad MILLER22 Jun
    • Re: [PATCH] Proposed patch for #29274: enable LSB-compliant buildsof MySQLJeff Licquia26 Jun