From: Date: June 20 2007 10:30am Subject: Re: Code reviews performed in public List-Archive: http://lists.mysql.com/internals/34760 Message-Id: MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323584-1161310497-1182328251=:12869" --8323584-1161310497-1182328251=:12869 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Vladimir, thanks for your message! I hope you don't mind if I send a copy of my reply= to the internals list as well, to avoid confusion. On Wed, 20 Jun 2007, Vladimir Shebordaev wrote: > Do you mean you encourage the Community to use BK client to commit the pa= tches > to the community trees? Doesn't it violate BitMover's license? Sorry if my message sounded misleading. This is primarily about commit mess= ages and reviews coming from developers employed by MySQL AB. This does not appl= y to developers that don't have a BK license and only can use the free BK client= =2E Our public BK trees on mysql.bkbits.net don't allow direct committing anywa= y,=20 patches have to go through one of our developers with commit privileges on = the internal trees, which are replicated to bkbits. > I thought this practice is deprecated, so I must send the hand-made propo= sed > patches to the Internals@ list exclusively... Well, probably I'm wrong. I > commit to my local clone, so you just get my notification e-mails. Yes, for patches contributed by non-MySQLers we still prefer reviewing and discussing them via the internals mailing list. We recently discovered a very useful tool for this: Quilt - http://savannah.nongnu.org/projects/quilt/ - some of our developers have started to use it for doing patch reviews instead of using the BK commit di= ffs. Have you heard about it? Bye, =09LenZ - --=20 Lenz Grimmer , Community Relations Manager, EMEA MySQL GmbH, http://www.mysql.de/, Radlkoferstr. 2, D-81373 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Kaj Arn=C3=B6 - HRB M=C3=BCnchen 162140 http://forge.mysql.com/ | http://planetmysql.org/ | http://dev.mysql.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) Comment: For info see http://quantumlab.net/pine_privacy_guard/ iD8DBQFGeOW+SVDhKrJykfIRAvtXAJ9TpRQXDcEN8NsFsIERZskNYQMghgCeOQp+ 4lqIVXZ7R6H6+dv+Y0DdhLY=3D =3DqHz/ -----END PGP SIGNATURE----- --8323584-1161310497-1182328251=:12869--