Re: [PATCH] Proposed patch for bug #24731, #24841

[Chad MILLER]

On 5 Jun 2007, at 09:26, Armin Schöffmann wrote:

> This patch should bring back shared-memory connections for windows  
> vista.
> Additionally, it will allow usage of sh-mem if either client or  
> server are run within a remote-desktop-session on WIN2K/XP/SRV2003/ 
> VISTA.
> Would be great to find it in one of the next builds...
> Regards,
> Armin.

Armin, thank you for the patch.

> --- 5.0repos/sql-common/client.c	2007-04-12 11:46:07.000000000 +0200
> +++ mysql-5.0/sql-common/client.c	2007-06-05 15:11:08.225593000 +0200
> @@ -416,7 +416,7 @@
>      shared_memory_base_name is unique value for each server
>      unique_part is uniquel value for each object (events and file- 
> mapping)
>    */
> -  suffix_pos = strxmov(tmp,shared_memory_base_name,"_",NullS);
> +  suffix_pos = strxmov(tmp,"Global\ 
> \",shared_memory_base_name,"_",NullS);

Should this be wrapped with a conditional, for versions of windows  
where that name is illegal?  I think that includes Windows NT, and  
perhaps 2000.  If so, what should the condition be?

>    strmov(suffix_pos, "CONNECT_REQUEST");
>    if (!(event_connect_request= OpenEvent(event_access_rights,  
> FALSE, tmp)))
>    {
> @@ -470,7 +470,7 @@
>      unique_part is uniquel value for each object (events and file- 
> mapping)
>      number_of_connection is number of connection between server  
> and client
>    */
> -  suffix_pos = strxmov 
> (tmp,shared_memory_base_name,"_",connect_number_char,
> +  suffix_pos = strxmov(tmp,"Global\ 
> \"shared_memory_base_name,"_",connect_number_char,
>  		       "_",NullS);
>    strmov(suffix_pos, "DATA");
>    if ((handle_file_map = OpenFileMapping 
> (FILE_MAP_WRITE,FALSE,tmp)) == NULL)


- chad

--
Chad Miller, Software Developer                         chad@stripped
MySQL Inc., www.mysql.com
Orlando, Florida, USA                                13-20z,  UTC-0400
Office: [phone]                         sip:6740@stripped



Attachment: [application/pgp-signature] This is a digitally signed message part PGP.sig