Re: [PATCH] first version of proposed patch for #28760

[Mark Leith]

Hi Kay,

Kay Roepke wrote:

> Hi!
>
> Below is a patch for the new replication delay feature (see <http:// 
> bugs.mysql.com/bug.php?id=28760>, <http://forge.mysql.com/worklog/ 
> task.php?id=344> for implementation details).
> The diff is against mysql-5.1-bk from last night, so it should apply  
> cleanly.
> It implements setting the replication delay by adding a new option to  
> the CHANGE MASTER statement, but currently doesn't add any new  
> options (like connect_retry and the like are).


Great!! One comment from me (not a proper code review yet):

   field_list.push_back(new Item_return_int("Connect_Retry", 10,
                                            MYSQL_TYPE_LONG));
+  field_list.push_back(new Item_return_int("Delay", 10,
+                                           MYSQL_TYPE_LONG));
   field_list.push_back(new Item_empty_string("Master_Log_File",
                                              FN_REFLEN));
   field_list.push_back(new Item_return_int("Read_Master_Log_Pos", 10,
@@ -1282,6 +1284,7 @@
     protocol->store(mi->user, &my_charset_bin);
     protocol->store((uint32) mi->port);
     protocol->store((uint32) mi->connect_retry);
+    protocol->store((uint32) mi->delay);

Can you instead put this new column at the *end* of the output please? 
We should not change the order of columns within SHOW / 
INFORMATION_SCHEMA output.

Thanks for the patch though - it would be great to see this get pushed! 
I'll leave the code review for dev however.

Best regards

Mark

-- 
Mark Leith, Senior Support Engineer
MySQL AB, Worcester, England, www.mysql.com
Are you MySQL certified?  www.mysql.com/certification