| List: | Internals | « Previous MessageNext Message » | |
| From: | Lenz Grimmer | Date: | April 22 2007 7:35pm |
| Subject: | Re: Patch 3 for #27894: mysqlbinlog formats timestamp wrong in comment | ||
| View as plain text | |||
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, On Fri, 20 Apr 2007, Chad MILLER wrote: > [add CC LenZ and Giuseppe] > > On 19 Apr 2007, at 20:01, Jorge Bernal Ordovás wrote: > >I went for allocating space. Here it goes > > > >http://people.warp.es/~koke/patches/27894-fix-printf_3.diff > > The indentation is two levels off, but I fixed that easily. I also changed > the "TODO: implement minimum width" comment. > > I'm happy with this, Jorge. Thank you very much. Excellent! Thanks a lot for your contribution, Jorge, and for reviewing and commenting on this, Chad. > I'll get another review from someone else, and then I expect it to be ready to > be applied. Since this is more than a few lines, someone will be in contact > with you about the Contributer License Agreement, if you haven't signed one > yet. Jorge, we require you to submit an Contributor License Agreement in order for us to be able to incorporate your patch. Please head over to http://forge.mysql.com/contribute/ for more details and an online form that you can use to send such an agreement to us. For reference, please add the Bug ID to the Comment field. Once we have received your agreement, Chad can proceed to apply the patch. Thanks! Let me know if you have any questions. Bye, LenZ - -- Lenz Grimmer <lenz@stripped>, Community Relations Manager, EMEA MySQL GmbH, http://www.mysql.de/, Radlkoferstr. 2, D-81373 München Geschäftsführer: Hans von Bell, Kaj Arnö - HRB München 162140 Don't miss the MySQL Conference & Expo 2007: http://mysqlconf.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) Comment: For info see http://quantumlab.net/pine_privacy_guard/ iD4DBQFGK50ASVDhKrJykfIRAlPKAJdofHZpC/0+W2Ke6LOvuPpEhHHnAJ9Rv2BC 2Qjq9dIffILqmC3HL0BOVw== =n3x+ -----END PGP SIGNATURE-----
