Re: Review 1 of patch 2 for #27894: mysqlbinlog formats timestamp wrong in comment

[Sergei Golubchik]

Hi!

On Apr 19, Chad MILLER wrote:
> On 19 Apr 2007, at 19:11, Jorge Bernal Ordovás wrote:
> >On 19/04/2007, at 15:58, Chad MILLER wrote:
> >>
> >I think the second case is what I was looking for. Anyway, is there
> >anything bad about doing a for-loop and my_b_write(info, '0', 1) in
> >terms or perfomance. Or it's just it feels wrong (I get that  feeling
> >but not sure why yet)?
> 
> Yeah, system calls are expensive, so I'd suggest something like...

System calls are expensive, but my_b_write() is not a syscall.

It's a macro that writes data to an IO_CACHE. Most of the time it'll be
just a memcpy. When a cache is full, it'll be a syscall (and more than
one, in fact).

Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Senior Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Radlkoferstr. 2, D-81373 München
       <___/  Geschäftsführer: Hans von Bell, Kaj Arnö - HRB
München 162140