From: Date: April 19 2007 11:50pm Subject: Re: fix error handling: pthread_key_create() does not set errno List-Archive: http://lists.mysql.com/internals/34559 Message-Id: MIME-Version: 1.0 (Apple Message framework v752.3) Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Apple-Mail-17--1003760885" Content-Transfer-Encoding: 7bit --Apple-Mail-17--1003760885 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed On 19 Apr 2007, at 11:34, Vasil Dimov wrote: > mysys/my_thr_init.c (in 5.1 and 5.0) reads: > > 84 if (pthread_key_create(&THR_KEY_mysys,0)) > 85 { > 86 fprintf(stderr,"Can't initialize threads: error %d\n",errno); > 87 return 1; > 88 } > > But pthread_key_create() does not set errno in case of an error but > rather emits the error code as a return value. Hi Vasil. Thank you. It needed a very simple fix. I patched the source and added Bug#27964 to track it. Tim reviewed it, and I committed it to his team trees. - chad -- Chad Miller, Software Developer chad@stripped MySQL Inc., www.mysql.com Orlando, Florida, USA 13-20z, UTC-0400 Office: +1 408 213 6740 sip:6740@stripped --Apple-Mail-17--1003760885 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (Darwin) iD8DBQFGJ+Qa/peCpMTxrLsRAjn3AJ9Ol87QX2eZO59DxnuAJFbqSlzLowCdFrIt 2AmtY8ejd+jRnDZDkLZ5ZuE= =3MVm -----END PGP SIGNATURE----- --Apple-Mail-17--1003760885--