List:Internals« Previous MessageNext Message »
From:Chad MILLER Date:April 19 2007 9:50pm
Subject:Re: fix error handling: pthread_key_create() does not set errno
View as plain text  
On 19 Apr 2007, at 11:34, Vasil Dimov wrote:

> mysys/my_thr_init.c (in 5.1 and 5.0) reads:
>
> 84   if (pthread_key_create(&THR_KEY_mysys,0))
> 85   {
> 86     fprintf(stderr,"Can't initialize threads: error %d\n",errno);
> 87     return 1;
> 88   }
>
> But pthread_key_create() does not set errno in case of an error but
> rather emits the error code as a return value.

Hi Vasil.  Thank you.

It needed a very simple fix.  I patched the source and added  
Bug#27964 to track it.  Tim reviewed it, and I committed it to his  
team trees.

- chad

--
Chad Miller, Software Developer                         chad@stripped
MySQL Inc., www.mysql.com
Orlando, Florida, USA                                13-20z,  UTC-0400
Office: +1 408 213 6740                         sip:6740@stripped



Attachment: [application/pgp-signature] This is a digitally signed message part PGP.sig
Thread
fix error handling: pthread_key_create() does not set errnoVasil Dimov19 Apr
  • Re: fix error handling: pthread_key_create() does not set errnoChad MILLER19 Apr