Re: Review of second patch for Bug#25615, "Status command doesn't report anymore the Queries per second avg"

[Sergei Golubchik]

Hi!

On Apr 09, joce@stripped wrote:
> Damned I didn't noticed my editor wasn't properly configured and was 
> inserting tabs instead of spaces.
> I'll fix it ASAP.

When you'll be doing it, please put DBUG_ASSERTs back to decimal.c,
only DBUG_PRINTs need to be removed, asserts are fine.
 
> joce@stripped a écrit :
> >Hi Chad,
> >
> >Here is a new patch which includes some fixes after testing + new test 
> >files.
> >It also includes the removal of DBUG functions from decimal.c
> >It passes the mysql-test, and no memory errors are reported by 
> >valgrind on the unittest.
> >
> >Makefile.am and decimal-t.c have to be put in a new unittest/strings/ 
> >directory.
> >
> > Jocelyn
> >
Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Senior Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Radlkoferstr. 2, D-81373 München
       <___/  Geschäftsführer: Hans von Bell, Kaj Arnö - HRB
München 162140