Re: Review of second patch for Bug#25615, "Status command doesn't report anymore the Queries per second avg"

[Sergei Golubchik]

Hi!

On Apr 08, joce@stripped wrote:
> Hi Sergei,
> 
> >>>--- mysql-5.2-ref/regex/Makefile.am        2007-03-02 19:24:43.000000000 
> +0100
> >>>+++ mysql-5.2/regex/Makefile.am    2007-03-23 00:47:50.000000000 +0100
> >>>@@ -17,7 +17,7 @@
> >>>
> >>>-LDADD= libregex.a $(top_builddir)/strings/libmystrings.a
> >>>+LDADD= libregex.a $(top_builddir)/strings/libmystrings.a          \
> >>>   $(top_builddir)/dbug/libdbug.a $(top_builddir)/mysys/libmysys.a \
> >>>   $(top_builddir)/strings/libmystrings.a
> >
> >I'm not sure it's a good idea to have libmystrings.a depending on
> >libmysys.a. It adds a circular dependency, as you can see.
> >  
> >What caused it ? malloc() ?
> 
> Actually, it's libmysys.a which depends on libmystrings.a through the
> use of strmake.  But libmystrings.a depends on libdbug.a because of
> the DBUG macro in decimal.c and libdbug.a depends on libmysys.a, hence
> the circular dependency.  Not sure how to solve this circular
> dependency.

Yes, this is nasty. I don't know how to fix it, may be merge everything
in one library ? Or split existing libraries, or move files between
them ?

Anyway, it cannot be considered a part of your bugfix of course :)
Here I'm only talking about the changes that you did, which made you to
add "libmystrings libdbug libmysys libmystrings" where libmystrings
alone sufficient. Looks like using decimal2string caused it.
Okay, until we have a solution, could you - as a workaround - remove
DBUG_PRINT's from decimal.c ? That should remove libmystrings dependency
on libdbug and libmysys.

Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Senior Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Radlkoferstr. 2, D-81373 München
       <___/  Geschäftsführer: Hans von Bell, Kaj Arnö - HRB
München 162140