Re: Review of second patch for Bug#25615, "Status command doesn't report anymore the Queries per second avg"

[[e-mail]]

Hi Sergei,

>  
>   
>>> --- mysql-5.2-ref/regex/Makefile.am	2007-03-02 19:24:43.000000000  +0100
>>> +++ mysql-5.2/regex/Makefile.am	2007-03-23 00:47:50.000000000 +0100
>>> @@ -17,7 +17,7 @@
>>>
>>> INCLUDES =		-I$(top_builddir)/include -I$(top_srcdir)/include
>>> noinst_LIBRARIES =	libregex.a
>>> -LDADD=			libregex.a $(top_builddir)/strings/libmystrings.a
>>> +LDADD=			libregex.a $(top_builddir)/strings/libmystrings.a
> $(top_builddir)/dbug/libdbug.a $(top_builddir)/mysys/libmysys.a
> $(top_builddir)/strings/libmystrings.a
>>>       
>
> I'm not sure it's a good idea to have libmystrings.a depending on
> libmysys.a. It adds a circular dependency, as you can see.
>   
> What caused it ? malloc() ?
>   

Actually, it's libmysys.a which depends on libmystrings.a through the 
use of strmake.
But libmystrings.a depends on libdbug.a because of the DBUG macro in 
decimal.c and libdbug.a depends on libmysys.a, hence the circular 
dependency.
Not sure how to solve this circular dependency.

  Jocelyn