Hi Chad,
I have attached a new version of the patch. I can upload it to the bug,
if it is ok.
I have rewritten most comments, done all the missing line breaks, and
adjusted the alignment.
Comments:
I left the @brief style in doxygen for now, as I believe the discussion
is ongoing.
But I collected most of the information on the actual method, and added
references to it.
Alignment:
I replaced most tabs by spaces, all I found about tabs, is that they are
8 spaces.
The only mention of tabs on the style guide is in the emacs/vim settings.
So I wasn't sure about the preference between spaces and tabs?
(If any tabs are left, they should align at 8 spaces)
One thing I left unchanged: "type2"
Postfix numbers to identifiers are used throughout the sql_yacc.yy file.
Also type2 is somehow "private" to type. It must not be used from
outside type.
It follows the naming convention of "create", "create2", "create2a",...
Best Regards
Martin
Chad MILLER wrote:
>
> On 20 Mar 2007, at 18:35, Martin Friebe wrote:
>> Just noting the latest tag on the bug, out of interest:
>> Is it the overall concept of the patch, or due to the coment below
>> (and an implied expectation to me, of uploading a "corrected" patch)?
>
> The tag is just my way of noting whether I have something to do or
> whether I'm waiting for something. I'll almost certainly apply your
> next patch when I receive it.
>
> - chad
>
>
>
>>
>
> --
> Chad Miller, Software Developer chad@stripped
> MySQL Inc., www.mysql.com
> Orlando, Florida, USA 13-20z, UTC-0400
> Office: +1 408 213 6740 sip:6740@stripped
>
>
Attachment: [text/x-patch] column_spec.patch
