Re: review of patch for Bug#25615, "Status command doesn't report anymore the Queries per second avg"

[joce]

Hi Chad,

I assume implementing %f is linked to WL#2934 ?
What's the status of the functions in decimal.c ?
(especially double2decimal and decimal2string)

Thanks,
  Jocelyn


> Jocelyn,
>
>
>> --- sql_parse.cc.old	2007-03-03 17:53:15.000000000 +0100
>> +++ sql_parse.cc	2007-03-03 17:53:31.000000000 +0100
>> @@ -2119,7 +2119,7 @@
>> 			&LOCK_status);
>>      calc_sum_of_all_status(&current_global_status_var);
>>      uptime= (ulong) (thd->start_time - start_time);
>> -    length= my_snprintf((char*) buff, buff_len - 1,
>> +    length= snprintf((char*) buff, buff_len - 1,
>>                          "Uptime: %lu  Threads: %d  Questions: %lu  "
>>                          "Slow queries: %lu  Opens: %lu  Flush
>> tables: %lu  "
>>                          "Open tables: %u  Queries per second avg:
>> %.3f",
>
>
> In addition to Sergei's comment that we should never use snprintf()
> outside the check for HAVE_SNPRINTF, the return value of snprintf()
> varies across implementations, so we should never even trust "length"
> in this case.  Thus, another reason we can't accept this approach.
> You're right, that adding floating-point decoding to my_snprintf() is
> the right approach.
>
> Jocelyn, are you comfortable implementing "%f"?
>
> - chad
>
> --
> Chad Miller, Software Developer                         chad@stripped
> MySQL Inc., www.mysql.com
> Orlando, Florida, USA                                13-20z,  UTC-0400
> Office: [phone]                         sip:6740@stripped
>
>
>