List:Internals« Previous MessageNext Message »
From:Jay Pipes Date:March 20 2007 2:25pm
Subject:Re: review of patch for Bug#27175: "invalid column attributes in
create/alter table"
View as plain text  
Jim Winstead wrote:
> On Mon, Mar 19, 2007 at 06:45:47PM -0400, Chad MILLER wrote:
>> Our Doxygen guidelines are new and (AFAIK) we don't have any options  
>> recommended, and I advocate that we make "JAVADOC_AUTOBRIEF" on, and  
>> so this could be
>>   /**
>>     BitMask of Bits used in "type" (only used in sql_yacc).  Keep  
>> track of
>>     each bit which has been explicit set to 0 or 1.  This allows to  
>> detect
>>     conflicts between user options.  Otherwise a user could specify
>>     "c int  PRIMARY KEY  NULL".
>>   */
>> which I think you'll agree is prettier.
> 
> +1 to that.
> 
> jim
> 
+1 from me.  Like David says, this would simplify things quite a bit, 
and give the output is the same, I'm all for it.

David, would you mind updating the doxyfile configuration file and the 
Makefile if needed?  Thanks!

Jay
Thread
review of patch for Bug#27175: "invalid column attributes in create/alter table"Chad MILLER19 Mar
  • Re: review of patch for Bug#27175: "invalid column attributes in create/alter table"Jim Winstead19 Mar
    • Re: review of patch for Bug#27175: "invalid column attributes increate/alter table"Jay Pipes20 Mar
      • Re: review of patch for Bug#27175: "invalid column attributes increate/alter table"David Shrewsbury20 Mar
      • "autobrief" in doxygen, was Re: review of patch for Bug#27175: "invalid column attributes in create/alter table"Chad MILLER20 Mar
  • Re: review of patch for Bug#27175: "invalid column attributes increate/alter table"David Shrewsbury20 Mar
  • Re: review of patch for Bug#27175: "invalid column attributes increate/alter table"Martin Friebe20 Mar
Re: review of patch for Bug#27175: "invalid column attributes increate/alter table"Martin Friebe21 Mar