List:Internals« Previous MessageNext Message »
From:David Shrewsbury Date:March 6 2007 5:56pm
Subject:Re: Proposed patch for Bug #26782
View as plain text  
Then with this explanation, I will let my initial patch
await approval.

-Dave


On Tue, 2007-03-06 at 18:31 +0100, Ingo Strüwing wrote:
> Hi Marko,
> 
> Marko Mäkelä schrieb:
> > On Sat, Mar 03, 2007 at 12:57:50PM +0100, Ingo Strüwing wrote:
> ...
> >> Good. In 5.1 table names don't have dots in them on the file system
> >> level. Please go ahead and create a table with a dot in its name. You'll
> >> see the name is recoded to avoid most special characters in the file
> >> name.
> > 
> > CREATE TABLE `#mysql50#dotted.table`(a INT);
> 
> Yes. You are right. I didn't think of the "#mysql50#" prefix.
> 
> This is to allow creating tables with the file name convention of 5.0. 
> And indeed we should also be able to handle old tables.
> 
> So I do now agree with the initial patch, provided that MY_REPLACE_EXT 
> does indeed replace arbitrary strings starting at the last dot. (I 
> didn't check it.)
> 
> > I hope that this prefix won't be disabled, because doing so would make
> > it very hard to upgrade InnoDB tables to 5.1 format.
> 
> Yes, I agree. Thanks for remembering me of this.
> 
> Regards
> Ingo
> -- 
> Ingo Strüwing, Senior Software Developer
> MySQL GmbH, Radlkoferstr. 2, D-81373 München
> Geschäftsführer: Hans von Bell, Kaj Arnö - HRB München 162140
> 
> 

Thread
Proposed patch for Bug #26782David Shrewsbury2 Mar
  • Re: Proposed patch for Bug #26782Ingo Strüwing2 Mar
    • Re: Proposed patch for Bug #26782David Shrewsbury2 Mar
      • Re: Proposed patch for Bug #26782David Shrewsbury2 Mar
        • Re: Proposed patch for Bug #26782Ingo Strüwing3 Mar
          • Re: Proposed patch for Bug #26782Marko Mäkelä4 Mar
            • Re: Proposed patch for Bug #26782Ingo Strüwing6 Mar
              • Re: Proposed patch for Bug #26782David Shrewsbury6 Mar
          • Re: Proposed patch for Bug #26782David Shrewsbury6 Mar