List:Internals« Previous MessageNext Message »
From:Ingo Strüwing Date:March 2 2007 8:06am
Subject:Re: Proposed patch for Bug #26782
View as plain text  
Hi,

Am Donnerstag, den 01.03.2007, 23:12 -0500 schrieb David Shrewsbury:
>    {
> +    char *iext= strrchr(name, '.');
> +    int have_iext= iext && !strcmp(iext, MI_NAME_IEXT);
>      fn_format(filename, name, "", MI_NAME_IEXT,
>                (MY_UNPACK_FILENAME |
>                 (flags & HA_DONT_TOUCH_DATA) ? MY_RETURN_REAL_PATH : 0) |
> -                MY_APPEND_EXT);
> +                (have_iext ? MY_REPLACE_EXT : MY_APPEND_EXT));
>      linkname_ptr=0;

Wouldn't it be sufficient to always use MY_REPLACE_EXT? Doesn't it
append the extension anyway if none exists?

And shouldn't it be fixed in 5.0 too?
 
Regards
Ingo
-- 
Ingo Strüwing, Senior Software Developer
MySQL GmbH, Radlkoferstr. 2, D-81373 München
Geschäftsführer: Hans von Bell, Kaj Arnö - HRB München 162140

Thread
Proposed patch for Bug #26782David Shrewsbury2 Mar
  • Re: Proposed patch for Bug #26782Ingo Strüwing2 Mar
    • Re: Proposed patch for Bug #26782David Shrewsbury2 Mar
      • Re: Proposed patch for Bug #26782David Shrewsbury2 Mar
        • Re: Proposed patch for Bug #26782Ingo Strüwing3 Mar
          • Re: Proposed patch for Bug #26782Marko Mäkelä4 Mar
            • Re: Proposed patch for Bug #26782Ingo Strüwing6 Mar
              • Re: Proposed patch for Bug #26782David Shrewsbury6 Mar
          • Re: Proposed patch for Bug #26782David Shrewsbury6 Mar