List:Internals« Previous MessageNext Message »
From:Marko Mäkelä Date:March 1 2007 1:40pm
Subject:Re: Missing thd accessors for storage engine plugins
View as plain text  
Hi Sergei,

On Thu, Feb 15, 2007 at 12:23:38PM +0200, Marko Mäkelä wrote:
> Hi!
> 
> On Thu, Feb 15, 2007 at 12:00:09AM +0100, Sergei Golubchik wrote:
> > Hi!
> > 
> > On Feb 14, Marko Mäkelä wrote:
> > > I am trying to make InnoDB a pluggable storage engine.  Among other
> > > things, I will need to remove references to some fields of class THD,
> > > which is declared as an incomplete type when compiling a plugin:
> > > 
> > > thd->options
> > > thd->query_id
> > > thd->query
> > > thd->lex->sql_command
> > > thd->lex->duplicates
> > > thd->in_sub_statement  [in a DBUG_ASSERT]
> > > thd->transaction.xid_state.xid
> > > 
> > > Will there be accessors to these fields?  If yes (or if they exist
> > > already), could someone please augment the above list with the names of
> > > the corresponding accessor functions?
> > 
> > Many of these are adressed by the patch I'm reviewing, we'll see what is
> > left after the patch is ready.
> 
> Ok, I'm looking forward to that.

Can you please send the patch as is?  I could then compose a list of
missing accessors, or even supply a patch that implements them.

	Marko
Thread
Missing thd accessors for storage engine pluginsMarko Mäkelä14 Feb
  • Re: Missing thd accessors for storage engine pluginsSergei Golubchik14 Feb
    • Re: Missing thd accessors for storage engine pluginsMarko Mäkelä15 Feb
      • Re: Missing thd accessors for storage engine pluginsMarko Mäkelä1 Mar