Below is the list of changes that have just been committed into a
4.0 repository of sasha. When sasha does a push, they will be propogated to
the main repository and within 24 hours after the push to the public repository.
For information on how to access the public repository
see http://www.mysql.com/doc/I/n/Installing_source_tree.html
ChangeSet@stripped, 2002-04-25 07:33:02-06:00, sasha@stripped
replication bugfixes
sql/slave.cc
1.167 02/04/25 07:33:01 sasha@stripped +6 -15
removed buggy loop
sql/slave.h
1.38 02/04/25 07:33:01 sasha@stripped +3 -1
fixed uninited variable use
# This is a BitKeeper patch. What follows are the unified diffs for the
# set of deltas contained in the patch. The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User: sasha
# Host: mysql.sashanet.com
# Root: /reiser-data/mysql-4.0
--- 1.166/sql/slave.cc Thu Apr 18 18:41:43 2002
+++ 1.167/sql/slave.cc Thu Apr 25 07:33:01 2002
@@ -1568,9 +1568,6 @@
static ulong read_event(MYSQL* mysql, MASTER_INFO *mi)
{
ulong len = packet_error;
- // for convinience lets think we start by
- // being in the interrupted state :-)
- int read_errno = EINTR;
// my_real_read() will time us out
// we check if we were told to die, and if not, try reading again
@@ -1579,27 +1576,21 @@
return packet_error;
#endif
- while (!abort_loop && !mi->abort_slave && len == packet_error &&
- read_errno == EINTR )
- {
- len = mc_net_safe_read(mysql);
- read_errno = errno;
- }
- if (abort_loop || mi->abort_slave)
- return packet_error;
+ len = mc_net_safe_read(mysql);
+
if (len == packet_error || (long) len < 1)
{
- sql_print_error("Error reading packet from server: %s (read_errno %d,\
+ sql_print_error("Error reading packet from server: %s (\
server_errno=%d)",
- mc_mysql_error(mysql), read_errno, mc_mysql_errno(mysql));
+ mc_mysql_error(mysql), mc_mysql_errno(mysql));
return packet_error;
}
if (len == 1)
{
sql_print_error("Slave: received 0 length packet from server, apparent\
- master shutdown: %s (%d)",
- mc_mysql_error(mysql), read_errno);
+ master shutdown: %s",
+ mc_mysql_error(mysql));
return packet_error;
}
--- 1.37/sql/slave.h Mon Apr 15 17:09:29 2002
+++ 1.38/sql/slave.h Thu Apr 25 07:33:01 2002
@@ -160,6 +160,7 @@
st_relay_log_info():info_fd(-1),cur_log_fd(-1),inited(0),
cur_log_init_count(0),
+ abort_slave(0),slave_running(0),
log_pos_current(0),abort_pos_wait(0),
skip_log_purge(0)
{
@@ -280,7 +281,8 @@
bool ignore_stop_event;
- st_master_info():fd(-1), io_thd(0), inited(0), old_format(0)
+ st_master_info():fd(-1), io_thd(0), inited(0), old_format(0),abort_slave(0),
+ slave_running(0)
{
host[0] = 0; user[0] = 0; password[0] = 0;
bzero(&file,sizeof(file));
| Thread |
|---|
| • bk commit into 4.0 tree | sasha | 25 Apr |