List:Internals« Previous MessageNext Message »
From:Jeremy Cole Date:September 5 2006 5:34pm
Subject:Re: SHOW PROFILE and PATCH/5.1: Change thd->proc_info accesses to
a macro
View as plain text  
Hi Marc,

First, it's good to see you with a mysql.com email address. :)  Two 
months ago with your contributions I said "he will work for MySQL soon" :)

> The code will be changed for step [0] to a macro, as you proposed.
> 
> Some minor changes :
> 
> - the macro name is THD_SET_PROC_INFO
> - it will expand to thd->set_proc_info(proc_info, __FILE__, __LINE__)
> 
> THD_SET_PROC_INFO should provide the entry point needed.
> 
> The THD::set_proc_info() method is only tentative for now,
> feel free to change it with later patches if needed.
> 
> I assume these minor changes are ok, please let us know otherwise.

Yes, no problem at all.

Is there a patch available yet?  (Or, has it been pushed to BK yet?)

Regards,

Jeremy

-- 
high performance mysql consulting
www.provenscaling.com
Thread
SHOW PROFILE and PATCH/5.1: Change thd->proc_info accesses to a macroJeremy Cole31 Jul
  • Re: SHOW PROFILE and PATCH/5.1: Change thd->proc_info accesses to a macroJim Winstead31 Jul
    • Re: SHOW PROFILE and PATCH/5.1: Change thd->proc_info accesses toa macroJeremy Cole1 Aug
  • Re: SHOW PROFILE and PATCH/5.1: Change thd->proc_info accesses toa macroLenz Grimmer31 Aug
    • Re: SHOW PROFILE and PATCH/5.1: Change thd->proc_info accesses to a macroElliot Murphy31 Aug
      • Re: SHOW PROFILE and PATCH/5.1: Change thd->proc_info accesses toa macroMarc Alff1 Sep
        • Re: SHOW PROFILE and PATCH/5.1: Change thd->proc_info accesses toa macroJeremy Cole1 Sep
    • Re: SHOW PROFILE and PATCH/5.1: Change thd->proc_info accesses toa macroMarc Alff5 Sep
      • Re: SHOW PROFILE and PATCH/5.1: Change thd->proc_info accesses toa macroJeremy Cole5 Sep