List:Internals« Previous MessageNext Message »
From:Stewart Smith Date:November 29 2005 2:55pm
Subject:bk commit into 4.1 tree (stewart:1.2474)
View as plain text  
Below is the list of changes that have just been committed into a local
4.1 repository of stewart. When stewart does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2474 05/11/29 14:55:26 stewart@stripped +1 -0
  ndb_size.pl:
    fix incorrect quoting of column name

  ndb/tools/ndb_size.pl
    1.5 05/11/29 14:55:08 stewart@stripped +3 -3
    fix incorrect quoting of column name

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	stewart
# Host:	willster.(none)
# Root:	/home/stewart/Documents/MySQL/4.1/cleanup

--- 1.4/ndb/tools/ndb_size.pl	2005-11-16 09:47:00 +01:00
+++ 1.5/ndb/tools/ndb_size.pl	2005-11-29 14:55:08 +01:00
@@ -146,9 +146,9 @@
 	elsif($type =~ /varchar/ || $type =~ /varbinary/)
 	{
 	    my $fixed= 1+$size;
-	    my @dynamic=$dbh->selectrow_array("select avg(length("
-					      .$dbh->quote($name)
-					      .")) from `".$table.'`');
+	    my @dynamic=$dbh->selectrow_array("select avg(length(`"
+					      .$name.
+					      ."`)) from `".$table.'`');
 	    $dynamic[0]=0 if !$dynamic[0];
 	    @realsize= ($fixed,$fixed,ceil($dynamic[0]));
 	}
Thread
bk commit into 4.1 tree (stewart:1.2474)Stewart Smith29 Nov