bk commit into 5.1 tree (mikron:1.1963)

[mikael]

Below is the list of changes that have just been committed into a local
5.1 repository of mikron. When mikron does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.1963 05/11/24 13:10:06 mikron@stripped +1 -0
  Review fixes

  sql/ha_partition.cc
    1.15 05/11/24 13:09:54 mikron@stripped +54 -9
    Review fixes

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	mikron
# Host:	mikael-ronstr-ms-dator.local
# Root:	/Users/mikron/wl2604

--- 1.14/sql/ha_partition.cc	2005-11-24 11:37:24 +01:00
+++ 1.15/sql/ha_partition.cc	2005-11-24 13:09:54 +01:00
@@ -4647,15 +4647,27 @@
 }
 
 /*
-  Given a starting key, and an ending key estimate the number of rows that
-  will exist between the two. end_key may be empty which in case determine
-  if start_key matches any rows.
-
-  Called from opt_range.cc by check_quick_keys().
-
-  monty: MUST be called for each range and added.
-	 Note that MySQL will assume that if this returns 0 there is no
-         matching rows for the range!
+  Find number of records in a range
+
+  SYNOPSIS
+    records_in_range()
+    inx                  Index number
+    min_key              Start of range
+    max_key              End of range
+
+  RETURN VALUE
+    Number of rows in range
+
+  DESCRIPTION
+    Given a starting key, and an ending key estimate the number of rows that
+    will exist between the two. end_key may be empty which in case determine
+    if start_key matches any rows.
+
+    Called from opt_range.cc by check_quick_keys().
+
+    monty: MUST be called for each range and added.
+          Note that MySQL will assume that if this returns 0 there is no
+          matching rows for the range!
 */
 
 ha_rows ha_partition::records_in_range(uint inx, key_range *min_key,
@@ -4674,6 +4686,16 @@
 }
 
 
+/*
+  Estimate upper bound of number of rows
+
+  SYNOPSIS
+    estimate_rows_upper_bound()
+
+  RETURN VALUE
+    Number of rows
+*/
+
 ha_rows ha_partition::estimate_rows_upper_bound()
 {
   ha_rows rows, tot_rows= 0;
@@ -4692,6 +4714,21 @@
 }
 
 
+/*
+  Is it ok to switch to a new engine for this table
+
+  SYNOPSIS
+    can_switch_engine()
+
+  RETURN VALUE
+    TRUE                  Ok
+    FALSE                 Not ok
+
+  DESCRIPTION
+    Used to ensure that tables with foreign key constraints are not moved
+    to engines without foreign key support.
+*/
+
 bool ha_partition::can_switch_engines()
 {
   handler **file;
@@ -4706,6 +4743,14 @@
   DBUG_RETURN(TRUE);
 }
 
+
+/*
+  Is table cache supported
+
+  SYNOPSIS
+    table_cache_type()
+
+*/
 
 uint8 ha_partition::table_cache_type()
 {