List:Internals« Previous MessageNext Message »
From:konstantin Date:November 19 2005 5:00pm
Subject:bk commit into 5.0 tree (konstantin:1.1979) BUG#14845
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of kostja. When kostja does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.1979 05/11/19 19:00:02 konstantin@stripped +1 -0
  A fix for Bug#14845 "mysql_stmt_fetch returns MYSQL_NO_DATA when 
  COUNT(*) is 0" (the test case has been pushed already)

  sql/sql_cursor.cc
    1.4 05/11/19 18:59:56 konstantin@stripped +1 -2
    Fix a return of an unitialized variable: return_zero_rows
    checks the return value of send_fields and in case it's 1
    doesn't call send_data. This caused creation of an empty result 
    set for the case when there is a cursor against a select with a 
    group function and no matching rows.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	konstantin
# Host:	dragonfly.local
# Root:	/opt/local/work/mysql-5.0-8568

--- 1.3/sql/sql_cursor.cc	2005-11-10 17:05:11 +03:00
+++ 1.4/sql/sql_cursor.cc	2005-11-19 18:59:56 +03:00
@@ -661,11 +661,10 @@
 
 bool Select_materialize::send_fields(List<Item> &list, uint flags)
 {
-  bool rc;
   DBUG_ASSERT(table == 0);
   if (create_result_table(unit->thd, unit->get_unit_column_types(),
                           FALSE, thd->options | TMP_TABLE_ALL_COLUMNS, ""))
     return TRUE;
-  return rc;
+  return FALSE;
 }
 
Thread
bk commit into 5.0 tree (konstantin:1.1979) BUG#14845konstantin19 Nov