List:Internals« Previous MessageNext Message »
From:gluh Date:November 7 2005 12:06pm
Subject:bk commit into 5.0 tree (gluh:1.1971) BUG#11491
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of gluh. When gluh does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.1971 05/11/07 16:06:05 gluh@stripped +17 -0
  Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                    SQL mode TRADITIONAL(2nd version)

  sql/field_conv.cc
    1.53 05/11/07 16:05:59 gluh@stripped +1 -2
    Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                      SQL mode TRADITIONAL

  mysql-test/t/strict.test
    1.20 05/11/07 16:05:59 gluh@stripped +4 -4
    Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                      SQL mode TRADITIONAL
      test change

  mysql-test/r/warnings.result
    1.35 05/11/07 16:05:59 gluh@stripped +3 -3
    Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                      SQL mode TRADITIONAL
      result change

  mysql-test/r/view.result
    1.130 05/11/07 16:05:59 gluh@stripped +1 -1
    Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                      SQL mode TRADITIONAL
      result change

  mysql-test/r/strict.result
    1.26 05/11/07 16:05:59 gluh@stripped +9 -9
    Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                      SQL mode TRADITIONAL
      result change

  mysql-test/r/ps_6bdb.result
    1.41 05/11/07 16:05:59 gluh@stripped +1 -1
    Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                      SQL mode TRADITIONAL
      result change

  mysql-test/r/ps_5merge.result
    1.39 05/11/07 16:05:59 gluh@stripped +2 -2
    Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                      SQL mode TRADITIONAL
      result change

  mysql-test/r/ps_4heap.result
    1.38 05/11/07 16:05:59 gluh@stripped +1 -1
    Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                      SQL mode TRADITIONAL
      result change

  mysql-test/r/ps_3innodb.result
    1.42 05/11/07 16:05:59 gluh@stripped +1 -1
    Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                      SQL mode TRADITIONAL
      result change

  mysql-test/r/ps_2myisam.result
    1.39 05/11/07 16:05:59 gluh@stripped +1 -1
    Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                      SQL mode TRADITIONAL
      result change

  mysql-test/r/null_key.result
    1.36 05/11/07 16:05:58 gluh@stripped +1 -1
    Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                      SQL mode TRADITIONAL
      result change

  mysql-test/r/null.result
    1.34 05/11/07 16:05:58 gluh@stripped +9 -9
    Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                      SQL mode TRADITIONAL
      result change

  mysql-test/r/key.result
    1.29 05/11/07 16:05:58 gluh@stripped +2 -2
    Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                      SQL mode TRADITIONAL
      result change

  mysql-test/r/insert_select.result
    1.36 05/11/07 16:05:58 gluh@stripped +2 -2
    Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                      SQL mode TRADITIONAL
      result change

  mysql-test/r/insert.result
    1.23 05/11/07 16:05:58 gluh@stripped +1 -1
    Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                      SQL mode TRADITIONAL
      result change

  mysql-test/r/create.result
    1.104 05/11/07 16:05:58 gluh@stripped +1 -1
    Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                      SQL mode TRADITIONAL
      result change

  mysql-test/r/auto_increment.result
    1.35 05/11/07 16:05:58 gluh@stripped +2 -2
    Fix for bug#11491 Misleading error message if not NULL column set to NULL,
                      SQL mode TRADITIONAL
      result change

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	gluh
# Host:	eagle.intranet.mysql.r18.ru
# Root:	/home/gluh/MySQL/Bugs/5.0.11491

--- 1.52/sql/field_conv.cc	Fri Sep 23 12:18:52 2005
+++ 1.53/sql/field_conv.cc	Mon Nov  7 16:05:59 2005
@@ -178,8 +178,7 @@
   }
   if (current_thd->count_cuted_fields == CHECK_FIELD_WARN)
   {
-    field->set_warning(MYSQL_ERROR::WARN_LEVEL_WARN,
-                       ER_WARN_NULL_TO_NOTNULL, 1);
+    field->set_warning(MYSQL_ERROR::WARN_LEVEL_WARN, ER_BAD_NULL_ERROR, 1);
     return 0;
   }
   if (!current_thd->no_errors)

--- 1.129/mysql-test/r/view.result	Thu Nov  3 13:38:37 2005
+++ 1.130/mysql-test/r/view.result	Mon Nov  7 16:05:59 2005
@@ -1480,7 +1480,7 @@
 insert into v3(a) select a from t2;
 insert into v3(b) select b from t2;
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'a' at row 2
+Warning	1048	Column 'a' cannot be null
 insert into v3(a) values (1) on duplicate key update a=a+10000+VALUES(a);
 select * from t1;
 a	b

--- 1.38/mysql-test/r/ps_2myisam.result	Tue Sep 27 20:07:20 2005
+++ 1.39/mysql-test/r/ps_2myisam.result	Mon Nov  7 16:05:59 2005
@@ -1302,7 +1302,7 @@
 set @arg01=2;
 execute stmt1 using @arg00, @arg01;
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'a' at row 1
+Warning	1048	Column 'a' cannot be null
 select a,b from t1 order by a;
 a	b
 0	two

--- 1.41/mysql-test/r/ps_3innodb.result	Tue Sep 27 20:07:20 2005
+++ 1.42/mysql-test/r/ps_3innodb.result	Mon Nov  7 16:05:59 2005
@@ -1285,7 +1285,7 @@
 set @arg01=2;
 execute stmt1 using @arg00, @arg01;
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'a' at row 1
+Warning	1048	Column 'a' cannot be null
 select a,b from t1 order by a;
 a	b
 0	two

--- 1.37/mysql-test/r/ps_4heap.result	Tue Sep 27 20:07:20 2005
+++ 1.38/mysql-test/r/ps_4heap.result	Mon Nov  7 16:05:59 2005
@@ -1286,7 +1286,7 @@
 set @arg01=2;
 execute stmt1 using @arg00, @arg01;
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'a' at row 1
+Warning	1048	Column 'a' cannot be null
 select a,b from t1 order by a;
 a	b
 0	two

--- 1.38/mysql-test/r/ps_5merge.result	Tue Sep 27 20:07:20 2005
+++ 1.39/mysql-test/r/ps_5merge.result	Mon Nov  7 16:05:59 2005
@@ -1328,7 +1328,7 @@
 set @arg01=2;
 execute stmt1 using @arg00, @arg01;
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'a' at row 1
+Warning	1048	Column 'a' cannot be null
 select a,b from t1 order by a;
 a	b
 0	two
@@ -4340,7 +4340,7 @@
 set @arg01=2;
 execute stmt1 using @arg00, @arg01;
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'a' at row 1
+Warning	1048	Column 'a' cannot be null
 select a,b from t1 order by a;
 a	b
 0	two

--- 1.40/mysql-test/r/ps_6bdb.result	Tue Sep 27 20:07:20 2005
+++ 1.41/mysql-test/r/ps_6bdb.result	Mon Nov  7 16:05:59 2005
@@ -1285,7 +1285,7 @@
 set @arg01=2;
 execute stmt1 using @arg00, @arg01;
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'a' at row 1
+Warning	1048	Column 'a' cannot be null
 select a,b from t1 order by a;
 a	b
 0	two

--- 1.34/mysql-test/r/auto_increment.result	Mon Jun  6 22:41:49 2005
+++ 1.35/mysql-test/r/auto_increment.result	Mon Nov  7 16:05:58 2005
@@ -232,7 +232,7 @@
 delete from t1 where a=0;
 update t1 set a=NULL where b=6;
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'a' at row 4
+Warning	1048	Column 'a' cannot be null
 update t1 set a=300 where b=7;
 SET SQL_MODE='';
 insert into t1(a,b)values(NULL,8);
@@ -274,7 +274,7 @@
 delete from t1 where a=0;
 update t1 set a=NULL where b=13;
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'a' at row 9
+Warning	1048	Column 'a' cannot be null
 update t1 set a=500 where b=14;
 select * from t1 order by b;
 a	b

--- 1.103/mysql-test/r/create.result	Mon Oct 31 10:18:22 2005
+++ 1.104/mysql-test/r/create.result	Mon Nov  7 16:05:58 2005
@@ -13,7 +13,7 @@
 Note	1050	Table 't1' already exists
 insert into t1 values (""),(null);
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'b' at row 2
+Warning	1048	Column 'b' cannot be null
 select * from t1;
 b
 

--- 1.22/mysql-test/r/insert.result	Wed Nov  3 14:39:31 2004
+++ 1.23/mysql-test/r/insert.result	Mon Nov  7 16:05:58 2005
@@ -63,7 +63,7 @@
 ERROR 23000: Column 'id' cannot be null
 insert into t1 values (1), (NULL), (2);
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'id' at row 2
+Warning	1048	Column 'id' cannot be null
 select * from t1;
 id
 1

--- 1.35/mysql-test/r/insert_select.result	Fri Oct 28 04:35:57 2005
+++ 1.36/mysql-test/r/insert_select.result	Mon Nov  7 16:05:58 2005
@@ -606,8 +606,8 @@
 create table t2(No int not null, Field int not null, Count int not null);
 insert into t2 Select null, Field, Count From t1 Where Month=20030901 and Type=2;
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'No' at row 1
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'No' at row 2
+Warning	1048	Column 'No' cannot be null
+Warning	1048	Column 'No' cannot be null
 select * from t2;
 No	Field	Count
 0	1	100

--- 1.28/mysql-test/r/key.result	Tue Aug 30 00:06:39 2005
+++ 1.29/mysql-test/r/key.result	Mon Nov  7 16:05:58 2005
@@ -159,8 +159,8 @@
 UNIQUE (c,i));
 INSERT INTO t1 (c) VALUES (NULL),(NULL);
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'c' at row 1
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'c' at row 2
+Warning	1048	Column 'c' cannot be null
+Warning	1048	Column 'c' cannot be null
 SELECT * FROM t1;
 c	i
 	1

--- 1.33/mysql-test/r/null.result	Sat Aug 27 10:23:33 2005
+++ 1.34/mysql-test/r/null.result	Mon Nov  7 16:05:58 2005
@@ -97,39 +97,39 @@
 Warning	1265	Data truncated for column 'd' at row 1
 UPDATE t1 SET d=NULL;
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'd' at row 1
+Warning	1048	Column 'd' cannot be null
 INSERT INTO t1 (a) values (null);
 ERROR 23000: Column 'a' cannot be null
 INSERT INTO t1 (a) values (1/null);
 ERROR 23000: Column 'a' cannot be null
 INSERT INTO t1 (a) values (null),(null);
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'a' at row 1
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'a' at row 2
+Warning	1048	Column 'a' cannot be null
+Warning	1048	Column 'a' cannot be null
 INSERT INTO t1 (b) values (null);
 ERROR 23000: Column 'b' cannot be null
 INSERT INTO t1 (b) values (1/null);
 ERROR 23000: Column 'b' cannot be null
 INSERT INTO t1 (b) values (null),(null);
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'b' at row 1
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'b' at row 2
+Warning	1048	Column 'b' cannot be null
+Warning	1048	Column 'b' cannot be null
 INSERT INTO t1 (c) values (null);
 ERROR 23000: Column 'c' cannot be null
 INSERT INTO t1 (c) values (1/null);
 ERROR 23000: Column 'c' cannot be null
 INSERT INTO t1 (c) values (null),(null);
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'c' at row 1
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'c' at row 2
+Warning	1048	Column 'c' cannot be null
+Warning	1048	Column 'c' cannot be null
 INSERT INTO t1 (d) values (null);
 ERROR 23000: Column 'd' cannot be null
 INSERT INTO t1 (d) values (1/null);
 ERROR 23000: Column 'd' cannot be null
 INSERT INTO t1 (d) values (null),(null);
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'd' at row 1
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'd' at row 2
+Warning	1048	Column 'd' cannot be null
+Warning	1048	Column 'd' cannot be null
 select * from t1;
 a	b	c	d
 	0	0000-00-00 00:00:00	0

--- 1.35/mysql-test/r/null_key.result	Tue Aug 23 20:08:00 2005
+++ 1.36/mysql-test/r/null_key.result	Mon Nov  7 16:05:58 2005
@@ -342,7 +342,7 @@
 );
 insert into t1 values(null,null),(1,1);
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'id2' at row 1
+Warning	1048	Column 'id2' cannot be null
 select * from t1;
 id	id2
 NULL	0

--- 1.25/mysql-test/r/strict.result	Wed Sep 14 03:41:37 2005
+++ 1.26/mysql-test/r/strict.result	Mon Nov  7 16:05:59 2005
@@ -989,16 +989,16 @@
 INSERT INTO t1 VALUES (103,'',NULL);
 ERROR 23000: Column 'col3' cannot be null
 UPDATE t1 SET col1=NULL WHERE col1 =100;
-ERROR 22004: Column set to default value; NULL supplied to NOT NULL column 'col1' at row 1
+ERROR 23000: Column 'col1' cannot be null
 UPDATE t1 SET col2 =NULL WHERE col2 ='hello';
-ERROR 22004: Column set to default value; NULL supplied to NOT NULL column 'col2' at row 1
+ERROR 23000: Column 'col2' cannot be null
 UPDATE t1 SET col2 =NULL where col3 IS NOT NULL;
-ERROR 22004: Column set to default value; NULL supplied to NOT NULL column 'col2' at row 1
+ERROR 23000: Column 'col2' cannot be null
 INSERT IGNORE INTO t1 values (NULL,NULL,NULL);
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'col1' at row 1
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'col2' at row 1
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'col3' at row 1
+Warning	1048	Column 'col1' cannot be null
+Warning	1048	Column 'col2' cannot be null
+Warning	1048	Column 'col3' cannot be null
 SELECT * FROM t1;
 col1	col2	col3
 100	hello	2004-08-20
@@ -1023,11 +1023,11 @@
 INSERT INTO t1 (col1) SELECT 1;
 ERROR HY000: Field 'col2' doesn't have a default value
 INSERT INTO t1 SELECT 1,NULL;
-ERROR 22004: Column set to default value; NULL supplied to NOT NULL column 'col2' at row 1
+ERROR 23000: Column 'col2' cannot be null
 INSERT IGNORE INTO t1 values (NULL,NULL);
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'col1' at row 1
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'col2' at row 1
+Warning	1048	Column 'col1' cannot be null
+Warning	1048	Column 'col2' cannot be null
 INSERT IGNORE INTO t1 (col1) values (3);
 Warnings:
 Warning	1364	Field 'col2' doesn't have a default value

--- 1.19/mysql-test/t/strict.test	Wed Sep 14 03:41:37 2005
+++ 1.20/mysql-test/t/strict.test	Mon Nov  7 16:05:59 2005
@@ -884,11 +884,11 @@
 INSERT INTO t1 (col1,col2,col3) VALUES (102, NULL, '2004-01-01');
 --error 1048
 INSERT INTO t1 VALUES (103,'',NULL);
---error 1263
+--error 1048
 UPDATE t1 SET col1=NULL WHERE col1 =100;
---error 1263
+--error 1048
 UPDATE t1 SET col2 =NULL WHERE col2 ='hello';
---error 1263
+--error 1048
 UPDATE t1 SET col2 =NULL where col3 IS NOT NULL;
 INSERT IGNORE INTO t1 values (NULL,NULL,NULL);
 SELECT * FROM t1;
@@ -908,7 +908,7 @@
 INSERT INTO t1 VALUES(default(col1),default(col2));
 --error 1364
 INSERT INTO t1 (col1) SELECT 1;
---error 1263
+--error 1048
 INSERT INTO t1 SELECT 1,NULL;
 INSERT IGNORE INTO t1 values (NULL,NULL);
 INSERT IGNORE INTO t1 (col1) values (3);

--- 1.34/mysql-test/r/warnings.result	Mon Sep 12 18:58:28 2005
+++ 1.35/mysql-test/r/warnings.result	Mon Nov  7 16:05:59 2005
@@ -86,7 +86,7 @@
 create table t1(a tinyint NOT NULL, b tinyint unsigned, c char(5));
 insert into t1 values(NULL,100,'mysql'),(10,-1,'mysql ab'),(500,256,'open source'),(20,NULL,'test');
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'a' at row 1
+Warning	1048	Column 'a' cannot be null
 Warning	1264	Out of range value adjusted for column 'b' at row 2
 Warning	1265	Data truncated for column 'c' at row 2
 Warning	1264	Out of range value adjusted for column 'a' at row 3
@@ -99,7 +99,7 @@
 alter table t1 add d char(2);
 update t1 set a=NULL where a=10;
 Warnings:
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'a' at row 2
+Warning	1048	Column 'a' cannot be null
 update t1 set c='mysql ab' where c='test';
 Warnings:
 Warning	1265	Data truncated for column 'c' at row 4
@@ -115,7 +115,7 @@
 Warning	1265	Data truncated for column 'b' at row 1
 Warning	1265	Data truncated for column 'b' at row 2
 Warning	1265	Data truncated for column 'b' at row 3
-Warning	1263	Column set to default value; NULL supplied to NOT NULL column 'a' at row 4
+Warning	1048	Column 'a' cannot be null
 Warning	1265	Data truncated for column 'b' at row 4
 insert into t2(b) values('mysqlab');
 Warnings:
Thread
bk commit into 5.0 tree (gluh:1.1971) BUG#11491gluh7 Nov