List:Internals« Previous MessageNext Message »
From:ramil Date:October 31 2005 12:28pm
Subject:bk commit into 4.1 tree (ramil:1.2458) BUG#14254
View as plain text  
Below is the list of changes that have just been committed into a local
4.1 repository of ram. When ram does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2458 05/10/31 16:28:45 ramil@stripped +1 -0
  Check for NULLs only if we don't replace column results,
  get real results after all checks.
  (see bug #14254: func_crypt.test fails on FreeBSD with --ps-protocol).

  client/mysqltest.c
    1.189 05/10/31 16:23:52 ramil@stripped +9 -4
    Check for NULLs only if we don't replace column results,
    get real results after all checks.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	ramil
# Host:	myoffice.izhnet.ru
# Root:	/usr/home/ram/work/mysql-4.1

--- 1.188/client/mysqltest.c	2005-10-05 15:21:50 +05:00
+++ 1.189/client/mysqltest.c	2005-10-31 16:23:52 +04:00
@@ -3272,18 +3272,23 @@
         /* Read result from each column */
         for (col_idx= 0; col_idx < num_fields; col_idx++)
         {
-          /* FIXME is string terminated? */
-          const char *val= (const char *)bind[col_idx].buffer;
-          ulonglong len= *bind[col_idx].length;
+          const char *val;
+          ulonglong len;
           if (col_idx < max_replace_column && replace_column[col_idx])
           {
             val= replace_column[col_idx];
             len= strlen(val);
           }
-          if (*bind[col_idx].is_null)
+          else if (*bind[col_idx].is_null)
           {
             val= "NULL";
             len= 4;
+          }
+          else
+          {
+            /* FIXME is string terminated? */
+            val= (const char *) bind[col_idx].buffer;
+            len= *bind[col_idx].length;
           }
           if (!display_result_vertically)
           {
Thread
bk commit into 4.1 tree (ramil:1.2458) BUG#14254ramil31 Oct