List:Internals« Previous MessageNext Message »
From:axel Date:October 17 2005 8:37pm
Subject:bk commit into 5.0 tree (schwenke:1.2008)
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of schwenke. When schwenke does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2008 05/10/17 20:37:21 schwenke@stripped +1 -0
  Merge aschwenke@stripped:/home/bk/mysql-5.0
  into  lmy003.xl.local:/home/schwenke/Work/MySQL/bk-internal-tree/mysql-5.0

  client/mysqldump.c
    1.208 05/10/17 20:37:11 schwenke@stripped +0 -0
    Auto merged

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	schwenke
# Host:	lmy003.xl.local
# Root:	/home/schwenke/Work/MySQL/bk-internal-tree/mysql-5.0/RESYNC

--- 1.207/client/mysqldump.c	2005-10-13 22:42:43 +02:00
+++ 1.208/client/mysqldump.c	2005-10-17 20:37:11 +02:00
@@ -3082,7 +3082,7 @@
 }
 
 /*
-  Get string of comma-separated primary key field names
+  Get string of comma-separated, quoted primary key field names
 
   SYNOPSIS
     char *primary_key_fields(const char *table_name)
@@ -3130,7 +3130,7 @@
   {
     /* Key is unique */
     do
-      result_length += strlen(row[4]) + 1;      /* + 1 for ',' or \0 */
+      result_length += strlen(row[4]) + 3;      /* 2 quotes + 1 for ',' or \0 */
     while ((row = mysql_fetch_row(res)) && atoi(row[3]) > 1);
   }
 
@@ -3147,9 +3147,9 @@
     }
     mysql_data_seek(res, 0);
     row = mysql_fetch_row(res);
-    end = strmov(result, row[4]);
+    end = strxmov(result, "`", row[4], "`", NullS);
     while ((row = mysql_fetch_row(res)) && atoi(row[3]) > 1)
-      end = strxmov(end, ",", row[4], NullS);
+      end = strxmov(end, ",`", row[4], "`", NullS);
   }
 
 cleanup:
Thread
bk commit into 5.0 tree (schwenke:1.2008)axel17 Oct